zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] mayawang commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling on a learner master
Date Tue, 25 Jun 2019 21:40:59 GMT
mayawang commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling
on a learner master
URL: https://github.com/apache/zookeeper/pull/995#discussion_r297405316
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerMaster.java
 ##########
 @@ -29,18 +31,81 @@
 /**
  * interface for keeping Observers in sync
  */
-public interface LearnerMaster {
+public abstract class LearnerMaster {
+    private static final Logger LOG = LoggerFactory.getLogger(LearnerMaster.class);
+
+    // Throttle when there are too many concurrent snapshots being sent to observers
+    private static final String MAX_CONCURRENT_SNAPSYNCS = "zookeeper.leader.maxConcurrentSnapSyncs";
 
 Review comment:
   Would this configuration be shared between leader and observer master? If so, I think there
are a few assumptions that worth a closer look.
   
   1) Leader and Followers are running on machines with similar capability (CPU, network bandwidth).
This assumption is usually true.
   2) ObserverMasters and Observers are also running on machines with similar capabilities
(CPU, network bandwidth). This assumption may not be true. E.g. If we deploy some Observers
in a different data center than the ObserverMaster, then the effective network bandwidth between
ObserverMaster and Observer could be significantly smaller than the bandwidth between Leader
and Followers. In this case, we might want to set a different maxConcurrentSnapSyncs for ObserverMaster
than Leader.
   
   Does those assumptions make sense here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message