zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] maoling commented on issue #994: ZOOKEEPER-3432 Improving zookeeper trace for performance and scalability
Date Tue, 25 Jun 2019 03:03:01 GMT
maoling commented on issue #994: ZOOKEEPER-3432 Improving zookeeper trace for performance and
scalability
URL: https://github.com/apache/zookeeper/pull/994#issuecomment-505261324
 
 
   @gmcatsf
   > Where is the best place to add documentation? Or shall it be a separate doc?
   
   Search around, there's no good place to add this doc.You can create a separate doc:e.g
 `zookeeperTracing.md`
   
   - almost 3000 line changes, too lazy to read. D. I have the following concerns:
     - the trace has something like `traceId`, if so, how to generate it?
     - this trace feature don't have a switch?
     - the sendReport Thread is asyn? enabling this feature has any performance issue?
   
   > This implementation is sending traces to external process and there is no persistence
in the pull request. It is up to the external process how to persist those traces. 
    -  is it not user-friendly? how to send traces to external process? what thing my external
process need to do?
   - Overall, the trace implements should comply with the opentracing specfication(https://github.com/opentracing/opentracing-java)?
Otw, too much work are exposed to the users.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message