zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] gmcatsf commented on issue #994: ZOOKEEPER-3432 Improving zookeeper trace for performance and scalability
Date Mon, 24 Jun 2019 19:19:08 GMT
gmcatsf commented on issue #994: ZOOKEEPER-3432 Improving zookeeper trace for performance and
scalability
URL: https://github.com/apache/zookeeper/pull/994#issuecomment-505143839
 
 
   > > > Writing the filter and reporting the tracings to a third-party distributed
tracing system(e.g zipkin) is a more simple way?
   > 
   > My thoughts on this is, the approach this patch took and third party tracing integration
is not mutually exclusive, and it's probably good to have a self contained tracing solution
for ZK w/o 3rd party dependency.
   > It would be good to keep the option open though to consider potential integration
to 3rd party system like openTracing while working on this patch.
   
   Adding TraceLoggerFactory and TraceLogger interface might help generalizing the implementation,
please kindly let me know if I should make the change here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message