zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] gmcatsf commented on issue #994: ZOOKEEPER-3432 Improving zookeeper trace for performance and scalability
Date Mon, 24 Jun 2019 19:12:06 GMT
gmcatsf commented on issue #994: ZOOKEEPER-3432 Improving zookeeper trace for performance and
scalability
URL: https://github.com/apache/zookeeper/pull/994#issuecomment-505141472
 
 
   > @gmcatsf awesome work.
   > 
   > * Cloud you plz add some details about how we visit the tracing chain´╝č
   
   This implementation is sending traces to external process and there is no persistence in
the pull request. It is up to the external process how to persist those traces. We have a
separate external process in c++ which receive those traces and then write them to scribe
or any other framework.
   
   > * In my knowledge, Writing the filter and reporting the tracings to a third-party
distributed tracing system(e.g `zipkin`) is a more simple way?
   
   I think it could co-exist with third-party tracing integration, though the code needs some
re-factory like changing TraceLogger to interface and adding a trace logger factor to load
different implementation. The reason behind current design is to export traces through a single
stateful socket connection without no new third-party library dependency in zookeeper.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message