zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] xoiss commented on issue #363: branch-3.4 -- bugfix -- ZOOKEEPER-2894
Date Sun, 23 Jun 2019 19:43:28 GMT
xoiss commented on issue #363: branch-3.4 -- bugfix -- ZOOKEEPER-2894
URL: https://github.com/apache/zookeeper/pull/363#issuecomment-504781041
 
 
   Hello!
   I have revised the issue description, and also I have fixed and reworked this PR.
   
   The improved issue: https://issues.apache.org/jira/browse/ZOOKEEPER-2894
   Essentially, I left it unchanged. I have read it now and I've found it more-or-less clear.
   Surely, it's very huge, but if one reads it with attention, I think she-or-he would get
the idea.
   The only thing, I emphasized subparts, where is the problem description, and where is the
proposal.
   
   The renewed PR: https://github.com/apache/zookeeper/pull/1000
   // hey, look! it's the number 1000 :)
   I have rebased it on the latest `branch-3.4`.
   As I can see, it passed all precommit checks.
   And the main thing, I've remedied my patch for the case of multi-threaded build.
   
   So, I hope now it comply with the PR-style.
   
   Thank you!
   Alex (aka xoiss)
   
   Please, revise my renewed PR: https://github.com/apache/zookeeper/pull/1000

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message