zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] xoiss commented on issue #360: branch-3.4 -- bugfix -- ZOOKEEPER-2891
Date Sun, 23 Jun 2019 19:07:27 GMT
xoiss commented on issue #360: branch-3.4 -- bugfix -- ZOOKEEPER-2891
URL: https://github.com/apache/zookeeper/pull/360#issuecomment-504778280
 
 
   Hello!
   I have reworked the issue description, and also I have reworked this PR.
   
   The improved issue: https://issues.apache.org/jira/browse/ZOOKEEPER-2891
   I have tried to make the description more clear.
   I'm not sure if I have succeeded, but I hope it became better.
   
   The renewed PR: https://github.com/apache/zookeeper/pull/999
   I have rebased it on the latest `branch-3.4`.
   As I can see, it passed all precommit checks.
   
   To **phunt**:
   >  I like this patch but it's missing tests. Can you include the tests from https://issues.apache.org/jira/secure/attachment/12671215/ZOOKEEPER-1636.patch
and resubmit?
   
   I'm not sure if I understand what should I do.
   I've checked the mentioned patch, and I see that it updates one of unit-tests - `TestMulti.cc`
   This test is currently in the repo, and my changes don't contradict with it.
   Moreover, it even does not have such a setup to reproduce the case which is patched with
my fixes.
   So, my question: what shall I do with it?
   
   Thank you!
   Alex (aka xoiss)
   
   Please, revise my renewed PR: https://github.com/apache/zookeeper/pull/999

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message