zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] anmolnar edited a comment on issue #959: ZOOKEEPER-3402: Add multiRead operation
Date Sat, 22 Jun 2019 21:33:07 GMT
anmolnar edited a comment on issue #959: ZOOKEEPER-3402: Add multiRead operation
URL: https://github.com/apache/zookeeper/pull/959#issuecomment-504699768
 
 
   @lvfangmin I tend to agree with you from OOP perspective, but I think if we were to make
this fully OOP compliant, the patch would be extremely large. As @szepet highlighted we would
need to introduce more classes to make the distinction everywhere: MultiReadRead/MultiTxnRecord,
ReadOp/TxnOp, MultiReadResponse/MultiTxnResponse, etc. I'm not sure about how large could
it be.
   
   Personally I like this `OpKind` approach though I haven't come across with it in practice.
Nice and easy. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message