zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] hanm commented on a change in pull request #986: ZOOKEEPER-3243: Add server-side request throttling
Date Sat, 22 Jun 2019 04:28:09 GMT
hanm commented on a change in pull request #986: ZOOKEEPER-3243: Add server-side request throttling
URL: https://github.com/apache/zookeeper/pull/986#discussion_r296431115
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -98,6 +98,14 @@
         Environment.logEnv("Server environment:", LOG);
     }
 
+    private static final String SHUTDOWN_TIMEOUT = "zookeeper.shutdownTimeout";
 
 Review comment:
   This is ambiguous (can be interpreted as server shutdown timeout especially given its defined
in this file). Consider properly name space it, such as `zookeeper.request_throttler.shutdownTimeout`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message