zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] hanm commented on a change in pull request #986: ZOOKEEPER-3243: Add server-side request throttling
Date Sat, 22 Jun 2019 04:28:09 GMT
hanm commented on a change in pull request #986: ZOOKEEPER-3243: Add server-side request throttling
URL: https://github.com/apache/zookeeper/pull/986#discussion_r296433171
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java
 ##########
 @@ -82,6 +80,22 @@ public ServerCnxn(final ZooKeeperServer zkServer) {
         this.zkServer = zkServer;
     }
 
+    /**
+     * Flag that indicates that this connection is known to be closed/closing
+     * and from which we can optionally ignore outstanding requests as part
+     * of request throttling. This flag may be false when a connection is
+     * actually closed (false negative), but should never be true with
+     * a connection is still alive (false positive).
 
 Review comment:
   This makes sense, though I've seen weird states of heap dumps where connections were set
as stale but not closed (aka stale but alive - false positive). Unfortunately I was unable
to reproduce this or identify the code culprit. All I am saying is to be cautious on relying
the stale flag inside the server connection object...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message