zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory
Date Fri, 21 Jun 2019 18:51:03 GMT
BELUGABEHR commented on a change in pull request #912: ZOOKEEPER-3365: Use Concurrent HashMap
with Counter in NettyServerCnxnFactory
URL: https://github.com/apache/zookeeper/pull/912#discussion_r296355010
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/NettyServerCnxnTest.java
 ##########
 @@ -110,6 +113,22 @@ public void testSendCloseSession() throws Exception {
         }
     }
 
+    /**
+     * In the {@link #setUp()} routine, the maximum number of connections per IP
+     * is set to 1. This tests that if more than one connection is attempted, the
+     * connection fails.
+     */
+    @Test(timeout = 40000, expected = ProtocolException.class)
+    public void testMaxConnectionPerIpSurpased() throws Exception {
+        Assert.assertTrue(
 
 Review comment:
   It is not common to add tests into a setup() method.  Better to put here and if it fails,
developer can easily pin-point the issue and add a breakpoint for debug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message