zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] phunt commented on a change in pull request #991: ZOOKEEPER-3433 zkpython build broken after maven migration
Date Wed, 19 Jun 2019 05:30:57 GMT
phunt commented on a change in pull request #991: ZOOKEEPER-3433 zkpython build broken after
maven migration
URL: https://github.com/apache/zookeeper/pull/991#discussion_r295125793
 
 

 ##########
 File path: zookeeper-contrib/zookeeper-contrib-zkpython/src/test/run_tests.sh
 ##########
 @@ -30,9 +30,9 @@ else
 fi
 
 # Find the build directory containing zookeeper.so
-SO_PATH=`find ../../../build/ -name "zookeeper.so" | head -1`
+SO_PATH=`find ../../build/ -name "zookeeper.so" | head -1`
 
 Review comment:
   I used ant to build the c client as maven doesn't seem to be working (the c client is not
being built even with "full-build" profile). That's the way it was always done on the past
- just continuing until we have a maven based approach. So with this we get back to status
quo - after the directory structure changes for maven I mean.
   
   I did a "ant clean compile compile-native" at the toplevel, then "ant compile" and "ant
test" within the zookeeper-contrib-zkpython directory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message