zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #980: ZOOKEEPER-3423:use the maven-like way to ignore the generated version java files and doc the cmd:'./zkServer.sh version'
Date Tue, 18 Jun 2019 06:46:57 GMT
eolivelli commented on a change in pull request #980: ZOOKEEPER-3423:use the maven-like way
to ignore the generated version java files and doc the cmd:'./zkServer.sh version'
URL: https://github.com/apache/zookeeper/pull/980#discussion_r294630466
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/version/util/VerGen.java
 ##########
 @@ -198,7 +198,7 @@ public static void main(String[] args) {
             } else {
                 rev = rev.trim();
             }
-            generateFile(new File("."), version, rev, args[2]);
+            generateFile(new File("../../../target/generated-sources/java"), version, rev,
args[2]);
 
 Review comment:
   It is better to have this path passed as a parameter, this way it will be easier to drive
this code from the pom.xml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message