zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] stickyhipp commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation
Date Mon, 17 Jun 2019 18:23:34 GMT
stickyhipp commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation
URL: https://github.com/apache/zookeeper/pull/959#discussion_r294443685
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java
 ##########
 @@ -574,6 +585,41 @@ public void processRequest(Request request) {
         }
     }
 
+    private Record handleReadRequest(int opCode, Record request, ServerCnxn cnxn, List<Id>
authInfo)
+            throws KeeperException, IOException {
+        switch(opCode) {
+            case OpCode.getChildren: {
+                GetChildrenRequest getChildrenRequest = (GetChildrenRequest) request;
 
 Review comment:
   nm, looks like you made the changes in line with the suggestion.  looks good.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message