zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] phunt commented on a change in pull request #980: ZOOKEEPER-3423:add VersionInfoMain.java to .gitignore and doc the cmd:'./zkServer.sh version'
Date Sat, 15 Jun 2019 19:53:23 GMT
phunt commented on a change in pull request #980: ZOOKEEPER-3423:add VersionInfoMain.java to
.gitignore and doc the cmd:'./zkServer.sh version'
URL: https://github.com/apache/zookeeper/pull/980#discussion_r294057794
 
 

 ##########
 File path: .gitignore
 ##########
 @@ -89,4 +89,5 @@ zookeeper-client/zookeeper-client-c/install-sh
 zookeeper-client/zookeeper-client-c/ltmain.sh
 zookeeper-client/zookeeper-client-c/missing
 zookeeper-server/src/main/java/org/apache/zookeeper/version/Info.java
+zookeeper-server/src/main/java/org/apache/zookeeper/version/VersionInfoMain.java
 
 Review comment:
   I just noticed this issue during a build, good to fix. I agree with Norbert - this should
be part of "generate-sources" phase/directory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message