zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] maoling commented on issue #988: fix: javadoc fixes in Utils
Date Sat, 15 Jun 2019 14:11:34 GMT
maoling commented on issue #988: fix: javadoc fixes in Utils
URL: https://github.com/apache/zookeeper/pull/988#issuecomment-502370182
 
 
   - Haha, [PR-983](https://github.com/apache/zookeeper/pull/983) wants to delete the related
codes in the this PR
   - IMO, it's time to clear up the all the checkstyle violations(turn on the `<failOnViolation>true</failOnViolation>`).
we can learn from the hbase whose checkstyle is very strict and ensures a very unified code
style.
   - @leesf if you're interested in this work,we can start from the `zookeeper-server` module.Look
at an example from [this](https://github.com/apache/hbase/commit/1b98a96caa09ee9be27d6bf028200fe6790ac726)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message