zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] szepet commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation
Date Fri, 14 Jun 2019 18:50:42 GMT
szepet commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation
URL: https://github.com/apache/zookeeper/pull/959#discussion_r293934485
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java
 ##########
 @@ -574,6 +585,41 @@ public void processRequest(Request request) {
         }
     }
 
+    private Record handleReadRequest(int opCode, Record request, ServerCnxn cnxn, List<Id>
authInfo)
+            throws KeeperException, IOException {
+        switch(opCode) {
+            case OpCode.getChildren: {
+                GetChildrenRequest getChildrenRequest = (GetChildrenRequest) request;
 
 Review comment:
   Hmm, that is something that I 100% percent agree but I do not see why this code is not
appropriate. The code of getChildren and getData only creates the record from the request
and then call the `handleGetChildrenRequest` or `handleGetDataRequest` function as well just
like the multiRead version.
   Or did I miss something and could we improve upon this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message