zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] maoling commented on a change in pull request #983: ZOOKEEPER-3391: Drop unused RecFormat(CSV/XML)
Date Fri, 14 Jun 2019 03:24:18 GMT
maoling commented on a change in pull request #983: ZOOKEEPER-3391: Drop unused RecFormat(CSV/XML)
URL: https://github.com/apache/zookeeper/pull/983#discussion_r293648019
 
 

 ##########
 File path: zookeeper-jute/src/main/java/org/apache/jute/ToStringOutputArchive.java
 ##########
 @@ -90,14 +85,14 @@ public void writeDouble(double d, String tag) throws IOException {
     
     public void writeString(String s, String tag) throws IOException {
         printCommaUnlessFirst();
-        stream.print(Utils.toCSVString(s));
+        stream.print(escapeString(s));
         throwExceptionOnError(tag);
     }
     
-    public void writeBuffer(byte buf[], String tag)
+    public void writeBuffer(byte[] buf, String tag)
     throws IOException {
         printCommaUnlessFirst();
-        stream.print(Utils.toCSVBuffer(buf));
+        stream.print(escapeBuffer(buf));
         throwExceptionOnError(tag);
     }
 
 Review comment:
   - `escapeBuffer` and `escapeString` can still be put into the `Utils.java`?
   - conservative and prudent about this PR. Do you have any test evidences about Backward
compatibility´╝č
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message