zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] stickyhipp commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation
Date Thu, 13 Jun 2019 00:57:46 GMT
stickyhipp commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation
URL: https://github.com/apache/zookeeper/pull/959#discussion_r293169748
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/MultiResponse.java
 ##########
 @@ -78,6 +82,12 @@ public void serialize(OutputArchive archive, String tag) throws IOException
{
                 case ZooDefs.OpCode.setData:
                     new SetDataResponse(((OpResult.SetDataResult) result).getStat()).serialize(archive,
tag);
                     break;
+                case ZooDefs.OpCode.getChildren:
+                    new GetChildrenResponse(((OpResult.GetChildrenResult) result).getChildren()).serialize(archive,
tag);
+                    break;
+                case ZooDefs.OpCode.getData:
+                    new GetDataResponse(((OpResult.GetDataResult) result).getData(), new
Stat()).serialize(archive, tag);
 
 Review comment:
   Let's return Stat from the GetData call:
   
   new GetDataResponse(((OpResult.GetDataResult) result).getData(),((OpResult.GetDataResult)
result).getStat()).serialize(archive, tag);

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message