zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] enixon commented on a change in pull request #978: ZOOKEEPER-3421: Better insight into Observer connections
Date Tue, 11 Jun 2019 17:38:29 GMT
enixon commented on a change in pull request #978: ZOOKEEPER-3421: Better insight into Observer
connections
URL: https://github.com/apache/zookeeper/pull/978#discussion_r292578826
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
 ##########
 @@ -1041,6 +1071,29 @@ public boolean synced() {
         return isAlive() && learnerMaster.getCurrentTick() <= tickOfNextAckDeadline;
     }
 
+    public synchronized Map<String, Object> getLearnerHandlerInfo() {
+        Map<String, Object> info = new LinkedHashMap<>();
 
 Review comment:
   LinkedHashMap preserves the ordering of insertion - my preference for anything that's going
to be displayed to a human. Pre-sizing makes sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message