zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] maoling commented on a change in pull request #975: ZOOKEEPER-3410:./zkTxnLogToolkit.sh will throw the NPE and stop the process of formatting txn logs due to the data's content is null
Date Mon, 10 Jun 2019 02:58:14 GMT
maoling commented on a change in pull request #975: ZOOKEEPER-3410:./zkTxnLogToolkit.sh will
throw the NPE and stop the process of formatting txn logs due to the data's content is null
URL: https://github.com/apache/zookeeper/pull/975#discussion_r291867269
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/TxnLogToolkit.java
 ##########
 @@ -332,7 +338,15 @@ private static String getDataStrFromTxn(Record txn) {
 
         return txnData.toString();
     }
-    
+
+    private static String checkNullToEmpty(byte[] data) {
 
 Review comment:
   Since the parameters is `byte[] data`, I think we may don't hava any one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message