zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] normanmaurer commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK
Date Fri, 07 Jun 2019 23:37:34 GMT
normanmaurer commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced
Netty flow control based on feedback from ZK
URL: https://github.com/apache/zookeeper/pull/919#discussion_r291781559
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
 ##########
 @@ -378,8 +411,33 @@ public void operationComplete(Future<Channel> future) {
             }
         }
     }
+
+    @Sharable
+    static class ReadIssuedTrackingHandler extends ChannelDuplexHandler {
+
 
 Review comment:
   nit: this should be a singleton instance... 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message