zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] hanm opened a new pull request #969: ZOOKEEPER-3416: Remove redundant ServerCnxnFactoryAccessor.
Date Wed, 05 Jun 2019 19:56:33 GMT
hanm opened a new pull request #969: ZOOKEEPER-3416: Remove redundant ServerCnxnFactoryAccessor.
URL: https://github.com/apache/zookeeper/pull/969
 
 
   We have two ways to access the private zkServer inside ServerCnxnFactory, and there is
really no need to keep maintaining both. We could remove ServerCnxnFactoryAccessor when we
added the public accessor for ServerCnxnFactory in ZOOKEEPER-1346, but we did not.
   
   The solution is to consolidate all access of the zkServer through the public accessor of
ServerCnxnFactory. The end result is cleaner code base and less confusion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message