zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] nkalmar commented on a change in pull request #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor
Date Wed, 05 Jun 2019 09:38:47 GMT
nkalmar commented on a change in pull request #905:  ZOOKEEPER-3359: Batch commits in the CommitProcessor

URL: https://github.com/apache/zookeeper/pull/905#discussion_r290656215
 
 

 ##########
 File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md
 ##########
 @@ -1358,6 +1358,19 @@ Both subsystems need to have sufficient amount of threads to achieve
peak read t
     Number of Commit Processor worker threads. If configured with 0 worker threads, the main
thread
     will process the request directly. The default value is the number of cpu cores.
 
+* *zookeeper.commitProcessor.maxReadBatchSize* :
 
 Review comment:
   Can you please add some hints on concrete numbers? 
   I know much depends on use-case, still, I think some general guide would be nice here.

   Something like "setting to an order of magnitude of 2-9... of 10s is... and setting it
to 100+ is only advisable when..."
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message