From issues-return-2229-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Jan 10 17:08:03 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C391318067E for ; Fri, 10 Jan 2020 18:08:02 +0100 (CET) Received: (qmail 34427 invoked by uid 500); 10 Jan 2020 17:08:02 -0000 Mailing-List: contact issues-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list issues@zookeeper.apache.org Received: (qmail 34414 invoked by uid 99); 10 Jan 2020 17:08:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jan 2020 17:08:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7D7F4E315A for ; Fri, 10 Jan 2020 17:08:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 4940278088F for ; Fri, 10 Jan 2020 17:08:00 +0000 (UTC) Date: Fri, 10 Jan 2020 17:08:00 +0000 (UTC) From: "Rabi Kumar K C (Jira)" To: issues@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (ZOOKEEPER-2293) Incorrect log level 'warn' is resulting in clutering of logs, Suggest to demote it to DEBUG from WARN MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rabi Kumar K C reassigned ZOOKEEPER-2293: ----------------------------------------- Assignee: Rabi Kumar K C > Incorrect log level 'warn' is resulting in clutering of logs, Suggest to demote it to DEBUG from WARN > ------------------------------------------------------------------------------------------------------ > > Key: ZOOKEEPER-2293 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2293 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.4.6 > Reporter: Praveena Manvi > Assignee: Rabi Kumar K C > Priority: Minor > > In https://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java > If readOnly flag is not being sent it gets logged as warning. Since we have enabled warning, the server gets filled up with messages like > Btw, readonly is optional and introduced later (http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode), > {code} > 015-08-14T11:03:11+00:00 Connection request from old client /192.168.24.16:14479; will be dropped if server is in r-o mode > ... > 2015-08-14T11:21:56+00:00 Connection request from old client > 2015-08-14T11:18:40+00:00 Connection request from old client /192.168.24.14:12135; will be dropped if server is in r-o mode > 2015-08-14T11:19:40+00:00 Connection request from old client /192.168.24.14:12310; will be dropped if server is in r-o mode > {code} > we are just forced to send read-only flag which is optional to avoid wrong logging level chosen by zookeeper. > {code} > boolean readOnly = false; > try { > readOnly = bia.readBool("readOnly"); > cnxn.isOldClient = false; > } catch (IOException e) { > // this is ok -- just a packet from an old client which > // doesn't contain readOnly field > LOG.warn("Connection request from old client " > + cnxn.getRemoteSocketAddress() > + "; will be dropped if server is in r-o mode"); > } > {code} > Suggest to demote the same to DEBUG as its not intended to warn in anyway. -- This message was sent by Atlassian Jira (v8.3.4#803005)