zookeeper-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Updated] (ZOOKEEPER-3676) Clean Up TxnLogProposalIterator
Date Tue, 07 Jan 2020 02:39:00 GMT

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

ASF GitHub Bot updated ZOOKEEPER-3676:
--------------------------------------
    Labels: pull-request-available  (was: )

> Clean Up TxnLogProposalIterator
> -------------------------------
>
>                 Key: ZOOKEEPER-3676
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3676
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>              Labels: pull-request-available
>
> * Use JDK Collections.emptyIterator where needed
>  * The the code manually returns an emptyIterator  when an error occurs, but it's also
possible to return an emptyIterator by passing 'null' to the TxnLogProposalIterator constructor. 
This is a bit ambiguous... why allow both?  Null values 'suck' so I think it's better to
just make sure that emptyIterator is returned where needed an throw NPE if a 'null' value
is passed in.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message