From issues-return-1303-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Sep 11 10:32:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E9B70180652 for ; Wed, 11 Sep 2019 12:32:02 +0200 (CEST) Received: (qmail 79954 invoked by uid 500); 11 Sep 2019 10:32:02 -0000 Mailing-List: contact issues-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list issues@zookeeper.apache.org Received: (qmail 79938 invoked by uid 99); 11 Sep 2019 10:32:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Sep 2019 10:32:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 01765E313A for ; Wed, 11 Sep 2019 10:32:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 2767978052E for ; Wed, 11 Sep 2019 10:32:00 +0000 (UTC) Date: Wed, 11 Sep 2019 10:32:00 +0000 (UTC) From: "Hudson (Jira)" To: issues@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3145) Potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3145?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16927470#comment-16927470 ]=20 Hudson commented on ZOOKEEPER-3145: ----------------------------------- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #690 (See [https://bui= lds.apache.org/job/ZooKeeper-trunk/690/]) ZOOKEEPER-3145: Fix potential watch missing issue due to stale pzxid (enric= o.olivelli: rev 42ea26b75105484ef0504396332c276952224158) * (edit) zookeeper-jute/src/main/resources/zookeeper.jute * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/util/Se= rializeUtils.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/= FuzzySnapshotRelatedTest.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/C= loseSessionTxnTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTre= e.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepReq= uestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeep= erServer.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepReq= uestProcessorTest.java > Potential watch missing issue due to stale pzxid when replaying CloseSess= ion txn with fuzzy snapshot > -------------------------------------------------------------------------= --------------------------- > > Key: ZOOKEEPER-3145 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3145 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.5.4, 3.6.0, 3.4.13 > Reporter: Fangmin Lv > Assignee: Fangmin Lv > Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 7h 20m > Remaining Estimate: 0h > > This is another issue I found recently, we haven't seen this problem on p= rod (or maybe we don't notice). > =C2=A0 > Currently, the CloseSession is not idempotent, executing the CloseSession= twice won't get the same result. > =C2=A0 > The problem is that closeSession will only check what's the ephemeral nod= es associated with that session bases on current states. Nodes deleted=C2= =A0during taking fuzzy snapshot=C2=A0won't be deleted again when replay the= txn. > =C2=A0 > This looks fine, since it's already gone, but there is problem with the p= zxid of the parent node. Snapshot is taken fuzzily, so it's possible that t= he parent had been serialized while the nodes are being deleted when execut= ing the closeSession Txn. The pzxid will not be updated in the snapshot whe= n replaying the closeSession txn, because=C2=A0doesn't know what's the=C2= =A0paths being deleted, so it won't patch the pzxid like what we did in the= deleteNode=C2=A0ZOOKEEPER-3125. > =C2=A0 > The inconsistent pzxid will lead to potential watch notification missing = when client reconnect with setWatches because of the staleness.=C2=A0 > =C2=A0 > This=C2=A0JIRA is going to fix those issues by adding the CloseSessionTxn= , it will record all those nodes being deleted in that CloseSession txn, so= that we know which nodes to update=C2=A0when=C2=A0replaying the txn. -- This message was sent by Atlassian Jira (v8.3.2#803003)