From issues-return-1112-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Sep 6 15:45:12 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 94D86180675 for ; Fri, 6 Sep 2019 17:45:12 +0200 (CEST) Received: (qmail 33181 invoked by uid 500); 7 Sep 2019 03:23:20 -0000 Mailing-List: contact issues-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list issues@zookeeper.apache.org Received: (qmail 32538 invoked by uid 99); 7 Sep 2019 03:23:17 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Sep 2019 03:23:17 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 66EFCE3135 for ; Fri, 6 Sep 2019 15:45:09 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 0C93B78239A for ; Fri, 6 Sep 2019 15:45:06 +0000 (UTC) Date: Fri, 6 Sep 2019 15:45:06 +0000 (UTC) From: "Enrico Olivelli (Jira)" To: issues@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ZOOKEEPER-878) finishPacket and conLossPacket should be methods of Packet MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-878: -------------------------------------- Fix Version/s: (was: 3.5.6) > finishPacket and conLossPacket should be methods of Packet > ---------------------------------------------------------- > > Key: ZOOKEEPER-878 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-878 > Project: ZooKeeper > Issue Type: Sub-task > Components: server > Reporter: Thomas Koch > Assignee: Thomas Koch > Priority: Minor > Fix For: 3.6.0, 3.5.7 > > Attachments: ZOOKEEPER-878.patch, ZOOKEEPER-878.patch > > > Those methods change the inner state of Packet, work on Packet so they should better be methods of class Packet. This may help to clarify synchronization. -- This message was sent by Atlassian Jira (v8.3.2#803003)