zookeeper-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Jira)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3501) unify the method:op2String()
Date Fri, 20 Sep 2019 17:09:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934580#comment-16934580
] 

Hudson commented on ZOOKEEPER-3501:
-----------------------------------

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #703 (See [https://builds.apache.org/job/ZooKeeper-trunk/703/])
ZOOKEEPER-3501: unify the method:op2String() (nkalmar: rev a179caa668882d6129ebb000ee60455de749d34f)
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/TraceFormatter.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/TxnLogToolkit.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/LogFormatter.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java
* (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/LocalSessionRequestTest.java


> unify the method:op2String()
> ----------------------------
>
>                 Key: ZOOKEEPER-3501
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3501
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: maoling
>            Assignee: maoling
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.6.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> there were two duplicated method
> *public static String op2String(int op)*
> in the code base:
>  
> {code:java}
> org.apache.zookeeper.server.TraceFormatter#op2String
> org.apache.zookeeper.server.Request#op2String
> {code}
>  
> and they are inconsistency, we should unify it and remain only one
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message