zookeeper-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3440) Fix Apache RAT check by excluding binary files (images)
Date Wed, 11 Sep 2019 21:43:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928026#comment-16928026
] 

Hadoop QA commented on ZOOKEEPER-3440:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version ) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4135//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4135//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4135//console

This message is automatically generated.

> Fix Apache RAT check by excluding binary files (images)
> -------------------------------------------------------
>
>                 Key: ZOOKEEPER-3440
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3440
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build, documentation
>    Affects Versions: 3.6.0
>            Reporter: Enrico Olivelli
>            Assignee: Enrico Olivelli
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 3.6.0, 3.5.6
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> I see this error on Jenkins as we are missing the exclusion for the images of the docs.
> {code:java}
> Unapproved licenses:
>   /home/jenkins/jenkins-slave/workspace/zookeeper-master-maven/zookeeper-docs/src/main/resources/markdown/images/state_dia.dia
> {code}
> We should also add this check to the precommit job on Travis (this will be part of the
commit) and on CI (this is a manual configuration, to be done after fixing this issue)



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message