From issues-return-734-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Aug 21 23:09:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id ED5D5180607 for ; Thu, 22 Aug 2019 01:09:01 +0200 (CEST) Received: (qmail 66134 invoked by uid 500); 21 Aug 2019 23:09:01 -0000 Mailing-List: contact issues-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list issues@zookeeper.apache.org Received: (qmail 66118 invoked by uid 99); 21 Aug 2019 23:09:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Aug 2019 23:09:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B3291E3084 for ; Wed, 21 Aug 2019 23:09:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 2C497780185 for ; Wed, 21 Aug 2019 23:09:00 +0000 (UTC) Date: Wed, 21 Aug 2019 23:09:00 +0000 (UTC) From: "Hadoop QA (Jira)" To: issues@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3448) Introduce MessageTracker to assist debug leader and leaner connectivity issues MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3448?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16912772#comment-16912772 ]=20 Hadoop QA commented on ZOOKEEPER-3448: -------------------------------------- -1 overall. GitHub Pull Request Build =20 +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified test= s. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of java= c compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.= 0.1) warnings. +1 release audit. The applied patch does not increase the total number= of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-b= uild/4102//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github= -pr-build/4102//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings= .html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr= -build/4102//console This message is automatically generated. > Introduce MessageTracker to assist debug leader and leaner connectivity i= ssues > -------------------------------------------------------------------------= ----- > > Key: ZOOKEEPER-3448 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3448 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.6.0 > Reporter: Michael Han > Assignee: Michael Han > Priority: Major > Labels: Twitter, pull-request-available > Time Spent: 3h 20m > Remaining Estimate: 0h > > We want to have better insight on the state of the world when learners lo= st connection with leader, so we need capture more information when that ha= ppens. We capture more information through MessageTracker which=C2=A0will r= ecord the last few sent and received messages at various protocol stage, an= d these information will be dumped to log files for further analysis. -- This message was sent by Atlassian Jira (v8.3.2#803003)