From issues-return-580-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sat Aug 3 10:17:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B75711802C7 for ; Sat, 3 Aug 2019 12:17:01 +0200 (CEST) Received: (qmail 65606 invoked by uid 500); 3 Aug 2019 10:17:01 -0000 Mailing-List: contact issues-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list issues@zookeeper.apache.org Received: (qmail 65596 invoked by uid 99); 3 Aug 2019 10:17:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Aug 2019 10:17:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 65963E08CE for ; Sat, 3 Aug 2019 10:17:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1EE7921405 for ; Sat, 3 Aug 2019 10:17:00 +0000 (UTC) Date: Sat, 3 Aug 2019 10:17:00 +0000 (UTC) From: "Hudson (JIRA)" To: issues@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3339) Improve Debug and Trace Log Statements MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899434#comment-16899434 ] Hudson commented on ZOOKEEPER-3339: ----------------------------------- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #645 (See [https://builds.apache.org/job/ZooKeeper-trunk/645/]) ZOOKEEPER-3339: Improve Debug and Trace Log Statements (fangmin: rev d84b7a682eb4601005db9fac886079b1a9a4d4b0) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/CommitProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/SessionTrackerImpl.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/client/ZooKeeperSaslClient.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java * (edit) zookeeper-recipes/zookeeper-recipes-lock/src/main/java/org/apache/zookeeper/recipes/lock/ProtocolSupport.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/Login.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java * (edit) zookeeper-recipes/zookeeper-recipes-lock/src/main/java/org/apache/zookeeper/recipes/lock/WriteLock.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/common/NettyUtils.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/SaslServerPrincipal.java * (edit) zookeeper-recipes/zookeeper-recipes-queue/src/main/java/org/apache/zookeeper/recipes/queue/DistributedQueue.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNIO.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/KeyAuthenticationProvider.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/util/SecurityUtils.java > Improve Debug and Trace Log Statements > -------------------------------------- > > Key: ZOOKEEPER-3339 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3339 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 4h > Remaining Estimate: 0h > > SLF4J supports an advanced feature called parameterized logging which can significantly boost logging performance for disabled logging statement. Review all logging and ensure that it adheres to parameterized logging. > https://www.slf4j.org/faq.html#logging_performance -- This message was sent by Atlassian JIRA (v7.6.14#76016)