zookeeper-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "TisonKun (Jira)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3523) Replace dummy watcher with a unified singleton
Date Wed, 28 Aug 2019 14:47:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917840#comment-16917840
] 

TisonKun commented on ZOOKEEPER-3523:
-------------------------------------

Thanks for your review [~bailei]. I update link field. It should have been automatically updated
by some logic though.

 

>I also noticed that you refactor some anonymous implemention of  Watcher to lambda
style. Is that related to this issue?

 

Thanks for your pointing out. I'm ok to revert those but think they are nit enough.

> Replace dummy watcher with a unified singleton
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-3523
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3523
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server, tests
>    Affects Versions: 3.6.0
>            Reporter: TisonKun
>            Assignee: TisonKun
>            Priority: Major
>             Fix For: 3.6.0
>
>
> Currently we have many anonymous subclasses of {{Watch}} all of which is just event
-> { }. We can reduce many subclasses in inherit tree by add a {{DUMMY_WATCHER}} in {{Watcher}}
interface and replace all of those usages.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message