From issues-return-475-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sun Jul 28 19:14:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id DB7E8180671 for ; Sun, 28 Jul 2019 21:14:01 +0200 (CEST) Received: (qmail 3531 invoked by uid 500); 28 Jul 2019 19:14:01 -0000 Mailing-List: contact issues-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list issues@zookeeper.apache.org Received: (qmail 3465 invoked by uid 99); 28 Jul 2019 19:14:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Jul 2019 19:14:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6733AE2E8A for ; Sun, 28 Jul 2019 19:14:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 184902661C for ; Sun, 28 Jul 2019 19:14:00 +0000 (UTC) Date: Sun, 28 Jul 2019 19:14:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3472) Treat check request as a write request which needs to wait for the check txn commit from leader MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3472?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16894775#comment-16894775 ]=20 Hadoop QA commented on ZOOKEEPER-3472: -------------------------------------- -1 overall. GitHub Pull Request Build =20 +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that = doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of java= c compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.= 0.1) warnings. +1 release audit. The applied patch does not increase the total number= of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-b= uild/4077//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github= -pr-build/4077//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings= .html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr= -build/4077//console This message is automatically generated. > Treat check request as a write request which needs to wait for the check = txn commit from leader > -------------------------------------------------------------------------= ---------------------- > > Key: ZOOKEEPER-3472 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3472 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.6.0, 3.5.5 > Reporter: Fangmin Lv > Assignee: Fangmin Lv > Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Check op is usually used as a sub op in multi, but from the ZooKeeper ser= ver implementation it can also called separately, the learner will forward = this request to leader, and the leader will check the version with the give= n version in the request, and generate a txn (error) in the quorum. > =C2=A0 > This is kind of a heavier sync to make sure when the client check on a l= earner, it is syncing up to date with leader when the check request is bein= g processed. The learner need to wait for this remote commit before reply t= o client in FinalRequestProcessor. > =C2=A0 > There is no explicit API exposed for check, so it seems not a problem, b= ut it could leave an issue there if=C2=A0the check API is exposed in the fu= ture. -- This message was sent by Atlassian JIRA (v7.6.14#76016)