From issues-return-453-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Fri Jul 26 10:00:02 2019
Return-Path: <issues-return-453-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 37D41180676
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 26 Jul 2019 12:00:02 +0200 (CEST)
Received: (qmail 69384 invoked by uid 500); 26 Jul 2019 10:00:01 -0000
Mailing-List: contact issues-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:issues@zookeeper.apache.org>
List-Id: <issues.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list issues@zookeeper.apache.org
Received: (qmail 69375 invoked by uid 99); 26 Jul 2019 10:00:01 -0000
Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jul 2019 10:00:01 +0000
Received: from jira-lw-us.apache.org (unknown [207.244.88.139])
	by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E6309E2F05
	for <issues@zookeeper.apache.org>; Fri, 26 Jul 2019 10:00:00 +0000 (UTC)
Received: from jira-lw-us.apache.org (localhost [127.0.0.1])
	by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4E74C265FF
	for <issues@zookeeper.apache.org>; Fri, 26 Jul 2019 10:00:00 +0000 (UTC)
Date: Fri, 26 Jul 2019 10:00:00 +0000 (UTC)
From: "tom.long (JIRA)" <jira@apache.org>
To: issues@zookeeper.apache.org
Message-ID: <JIRA.13243579.1562567282000.54165.1564135200319@Atlassian.JIRA>
In-Reply-To: <JIRA.13243579.1562567282000@Atlassian.JIRA>
References: <JIRA.13243579.1562567282000@Atlassian.JIRA> <JIRA.13243579.1562567282825@jira-lw-us.apache.org>
Subject: [jira] [Resolved] (ZOOKEEPER-3457) Code optimization in
 QuorumCnxManager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/ZOOKEEPER-3457?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:all-tabpanel ]

tom.long resolved ZOOKEEPER-3457.
---------------------------------
      Resolution: Fixed
    Release Note: https://github.com/apache/zookeeper/pull/1021

> Code optimization in QuorumCnxManager
> -------------------------------------
>
>                 Key: ZOOKEEPER-3457
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3457
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: quorum
>    Affects Versions: 3.5.5
>            Reporter: tom.long
>            Priority: Trivial
>              Labels: easyfix, pull-request-available
>             Fix For: 3.5.5
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Dear=C2=A0developer:
> I=C2=A0think=C2=A0the=C2=A0following=C2=A0code=C2=A0in=C2=A0line=C2=A0623=
=C2=A0of=C2=A0the=C2=A0QuorumCnxManager=C2=A0class=C2=A0can=C2=A0be=C2=A0op=
timized:
> {code:java}
> ArrayBlockingQueue<ByteBuffer>=C2=A0bq=C2=A0=3D=C2=A0new=C2=A0ArrayBlocki=
ngQueue<ByteBuffer>(
> SEND_CAPACITY);
> ArrayBlockingQueue<ByteBuffer>=C2=A0oldq=C2=A0=3D=C2=A0queueSendMap.putIf=
Absent(sid,=C2=A0bq);
> if=C2=A0(oldq=C2=A0!=3D=C2=A0null)=C2=A0{
> addToSendQueue(oldq,=C2=A0b);
> }=C2=A0else=C2=A0{
> addToSendQueue(bq,=C2=A0b);
> }
> {code}
> The=C2=A0optimization=C2=A0is=C2=A0as=C2=A0follows:
> {code:java}
> ArrayBlockingQueue<ByteBuffer>=C2=A0bq=C2=A0=3D=C2=A0queueSendMap.compute=
IfAbsent(sid,=C2=A0serverId=20
>  ->=C2=A0new=C2=A0ArrayBlockingQueue<>(SEND_CAPACITY));
> addToSendQueue(bq,=C2=A0b);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)