zookeeper-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3472) Treat check request as a write request which needs to wait for the check txn commit from leader
Date Sun, 28 Jul 2019 19:14:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894775#comment-16894775
] 

Hadoop QA commented on ZOOKEEPER-3472:
--------------------------------------

-1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require
tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4077//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4077//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4077//console

This message is automatically generated.

> Treat check request as a write request which needs to wait for the check txn commit from
leader
> -----------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-3472
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3472
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.6.0, 3.5.5
>            Reporter: Fangmin Lv
>            Assignee: Fangmin Lv
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.6.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Check op is usually used as a sub op in multi, but from the ZooKeeper server implementation
it can also called separately, the learner will forward this request to leader, and the leader
will check the version with the given version in the request, and generate a txn (error) in
the quorum.
>   
>  This is kind of a heavier sync to make sure when the client check on a learner, it is
syncing up to date with leader when the check request is being processed. The learner need
to wait for this remote commit before reply to client in FinalRequestProcessor.
>   
>  There is no explicit API exposed for check, so it seems not a problem, but it could
leave an issue there if the check API is exposed in the future.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message