zookeeper-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enrico Olivelli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3431) clear up the all the checkstyle violations in the zookeeper-server module
Date Tue, 18 Jun 2019 11:35:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866507#comment-16866507
] 

Enrico Olivelli commented on ZOOKEEPER-3431:
--------------------------------------------

[~maoling] we have to discuss this topic with the community.
I have experience on BookKeeper, we had to clean up groups of packages.
This is the kind of stuff that invalidates all of the pending pull requests.

I have already sett up a basic checkstyle configuration file and it is already active but
it is performing only very basic checks (like no 'author' tags)
see ZOOKEEPER-3362

I will appreciate very much if you want to drive this effort, personally I would start this
stuff after 3.6.0 release, once we consolidate current master and the maven build. 
I would have sent an email on the dev@ list soon

We also have to agree on the checkstyle configuration, it is not trivial, I would take the
file from HBase, BookKeeper or other ASF projects on the Haddoop ecosystem.


> clear up the all the checkstyle violations in the zookeeper-server module
> -------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-3431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3431
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: maoling
>            Priority: Major
>             Fix For: 3.6.0
>
>
> it's time to clear up the all the checkstyle violations(turn on theĀ {{<failOnViolation>true</failOnViolation>}}).
we can learn from the hbase whose checkstyle is very strict and ensures a very unified code
style.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message