zookeeper-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grayson Chao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2342) Migrate to Log4J 2.
Date Thu, 06 Jun 2019 23:05:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858154#comment-16858154

Grayson Chao commented on ZOOKEEPER-2342:

Hi all. At Facebook, we'd like to upgrade to Log4j2 for performance reasons. I'm thrilled
to see that [~praste] and [~cnauroth] have done the heavy lifting already (thanks!), but LOG4J2-63 appears
to be a blocker for merging either of their patches as-is.

Per [~flyinprogrammer], we do need to rip the bandaid off eventually, and I happen to be motivated
by my employer to make this happen.

My understanding is that we have no choice but to complete LOG4J2-63 (Log4j1 .properties configs)
if we hope to retain backward compatibility post-upgrade. That issue actually states that
the Log4j team isn't targeting backward compatibility for XML-based configs, but given ZK's
heavy emphasis on backward compatibility, I'd propose going above and beyond to support _all_
Log4j 1 configs in Log4j2.

Am I misunderstanding the situation, and does anyone see an alternative way forward?

cc [~nixon], [~lvfangmin] - I'm coming from a pure FB context and I don't know the history
here, so if I made any mistakes, maybe one of you will be able to quickly correct me :)

> Migrate to Log4J 2.
> -------------------
>                 Key: ZOOKEEPER-2342
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2342
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Major
>             Fix For: 3.6.0
>         Attachments: ZOOKEEPER-2342.001.patch
> ZOOKEEPER-1371 removed our source code dependency on Log4J.  It appears that this also
removed the Log4J SLF4J binding jar from the runtime classpath.  Without any SLF4J binding
jar available on the runtime classpath, it is impossible to write logs.
> This JIRA investigated migration to Log4J 2 as a possible path towards resolving the
bug introduced by ZOOKEEPER-1371.  At this point, we know this is not feasible short-term.
 This JIRA remains open to track long-term migration to Log4J 2.

This message was sent by Atlassian JIRA

View raw message