From dev-return-83136-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Tue Oct  8 07:32:03 2019
Return-Path: <dev-return-83136-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 565E8180654
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  8 Oct 2019 09:32:03 +0200 (CEST)
Received: (qmail 56192 invoked by uid 500); 8 Oct 2019 07:32:02 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 56137 invoked by uid 99); 8 Oct 2019 07:32:02 -0000
Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Oct 2019 07:32:02 +0000
Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172])
	by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2961CE30A4
	for <dev@zookeeper.apache.org>; Tue,  8 Oct 2019 07:32:00 +0000 (UTC)
Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1])
	by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 29CA078007D
	for <dev@zookeeper.apache.org>; Tue,  8 Oct 2019 07:32:00 +0000 (UTC)
Date: Tue, 8 Oct 2019 07:32:00 +0000 (UTC)
From: "maoling (Jira)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13261052.1570519870000.24017.1570519920109@Atlassian.JIRA>
In-Reply-To: <JIRA.13261052.1570519870000@Atlassian.JIRA>
References: <JIRA.13261052.1570519870000@Atlassian.JIRA> <JIRA.13261052.1570519870659@jira-he-de>
Subject: [jira] [Created] (ZOOKEEPER-3570) add the constant for cxid
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

maoling created ZOOKEEPER-3570:
----------------------------------

             Summary: add the constant for cxid
                 Key: ZOOKEEPER-3570
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3570
             Project: ZooKeeper
          Issue Type: Improvement
          Components: server
    Affects Versions: 3.6.0
            Reporter: maoling


in the *ClientCnxn*, we had hard-code cxid which is not elegant.

we need a=C2=A0constant for cxid
{code:java}
if (replyHdr.getXid() =3D=3D -2) {
    // -2 is the xid for pings
    if (LOG.isDebugEnabled()) {
        LOG.debug("Got ping response for sessionid: 0x"
                  + Long.toHexString(sessionId)
                  + " after "
                  + ((System.nanoTime() - lastPingSentNs) / 1000000)
                  + "ms");
    }
    return;
}
if (replyHdr.getXid() =3D=3D -4) {
    // -4 is the xid for AuthPacket
    if (replyHdr.getErr() =3D=3D KeeperException.Code.AUTHFAILED.intValue()=
) {
        state =3D States.AUTH_FAILED;
        eventThread.queueEvent(new WatchedEvent(Watcher.Event.EventType.Non=
e, Watcher.Event.KeeperState.AuthFailed, null));
        eventThread.queueEventOfDeath();
    }
    if (LOG.isDebugEnabled()) {
        LOG.debug("Got auth sessionid:0x" + Long.toHexString(sessionId));
    }
    return;
}
if (replyHdr.getXid() =3D=3D -1) {
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)