From dev-return-82816-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Sep 11 21:46:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D287E18063F for ; Wed, 11 Sep 2019 23:46:04 +0200 (CEST) Received: (qmail 89588 invoked by uid 500); 11 Sep 2019 21:46:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 89571 invoked by uid 99); 11 Sep 2019 21:46:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Sep 2019 21:46:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4A6E8180676 for ; Wed, 11 Sep 2019 21:46:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.801 X-Spam-Level: * X-Spam-Status: No, score=1.801 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id DNcbZPsMMQYR for ; Wed, 11 Sep 2019 21:46:00 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::342; helo=mail-ot1-x342.google.com; envelope-from=eolivelli@gmail.com; receiver= Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id BC0517DD5E for ; Wed, 11 Sep 2019 21:45:59 +0000 (UTC) Received: by mail-ot1-x342.google.com with SMTP id s28so24069601otd.4 for ; Wed, 11 Sep 2019 14:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=LGr9oOckdesbVdSV6ndZLGJBVz98amdmyF/Q5Vt6NK4=; b=EtSGuMOPHseRAJpmZxFD6UzpBZpEYMn8gbCbvEaSM/Q9h/kjzECMh0kTlMuKVcPi6Q maaSCt9jutJgtF0UnFtoU0eKPsYr5IisG+R7gmBg8dThz2nj9jwV7/2D8/K0ESq/ZpxF PLXUNERNJJ4wgtpfeSB28a+0CJ9nVH+Bh2+vys7t0bRtch6tpI9w84z2JbB9ElS9GF64 1YkyDQwCudQWEOvX8TY1TLO3sEnfXf5op1Z8uO5FYcN+DrbeLv+jLeDAV+TRIJ/MGm7d lJVviKyL75Kk1w0KP7ag+XrjE2yax5AuaVXciLsNJh7xPXmDkMdLdzDhFCrkT2MoEev8 jw0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=LGr9oOckdesbVdSV6ndZLGJBVz98amdmyF/Q5Vt6NK4=; b=pMCcILIXI2D9pS734Kudvp4Ue1gVFsc3vtCWSA5EhUyk9rDw1rwBM/6EpAN2cZuQNG BdS7unqC7kbaw9fDIY0zQGVU25RGCZfRSMHHWXjAGGQNY1nSho6XskIAmG1SebTsIaSx mzkUA5wypRMPVBCJaqzp3kL8F9V1ddfZC4fAKUnT5dTHIWP34Gf39MxPZQHuMJ5uBjJo 6PkjFNF1bkbTXsiheUCDOUC0drTVzHBo24FoH/CgaqbVBk/i9uIj8s3v+iXu109lGo3e YzJ92tJOfa9LnKA2x3BSZbpmzFxxPNuHoJDYhCsluYlXFrafKEQwCY/Q2wMiUn8lZYlP L6uA== X-Gm-Message-State: APjAAAX/F6JMAlkBPXUKu9uuDK5DODB6++r32JoX3TXpSrjo9DRq66YT lmZoEv5hkQiuewoRLTJnU/6Lfx621zPh2vPObAjgq0kr X-Google-Smtp-Source: APXvYqwLBAViRRtpTsXqdBkEf4pHL3NRNt4nBIIRmAPFxSKbcX4Ow42SyjQX5sBw7/Mobred4x3zx0sLml+qSiHXsFU= X-Received: by 2002:a9d:6218:: with SMTP id g24mr31397407otj.326.1568238353141; Wed, 11 Sep 2019 14:45:53 -0700 (PDT) MIME-Version: 1.0 References: <7E704C23-029E-43AE-8538-B4017701C30D@apache.org> <4e87b2e085a920810dea6112cfc6551774b15703.camel@apache.org> <6DC54EE0-35DE-4AFA-96AD-D7546DF0EBCC@apache.org> In-Reply-To: From: Enrico Olivelli Date: Wed, 11 Sep 2019 23:45:40 +0200 Message-ID: Subject: Re: Flaky test X509UtilTest.testClientRenegotiationFails ? To: DevZooKeeper Content-Type: multipart/alternative; boundary="000000000000f654cf05924df126" --000000000000f654cf05924df126 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I found the issue, the test falls into a race condition, so on a slow machine the test become more "flaky". It is interesting that on modern JDKs even on a slow machine the test never fails. here is the fix https://github.com/apache/zookeeper/pull/1088/files This is for branch-3.5, I will cherry pick to branch-3.5.6 I have also sent another patch for branch-3.5 to be cherry picked to branch-3.5.6 about Apache RAT check https://issues.apache.org/jira/browse/ZOOKEEPER-3440 https://github.com/apache/zookeeper/pull/1086 it is only a backport from master Please take a look After those commits I am close to sending the VOTE email for 3.5.6 Cheers Enrico Il giorno mer 11 set 2019 alle ore 17:56 Enrico Olivelli < eolivelli@gmail.com> ha scritto: > I have re run again the tests with jdk8 + MacOs without problem. > > The Linux box in which I have problems has only 2 cores, maybe such > problem is only with machines with a small number of cores > > Enrico > > Il giorno mer 11 set 2019 alle ore 15:27 Enrico Olivelli < > eolivelli@gmail.com> ha scritto: > >> I am on Fedora+adoptopenjdk. >> I will be back with debug I info >> >> On my Mac the VM is crashing! >> >> Enrico >> >> Il mer 11 set 2019, 14:14 Andor Molnar ha scritto: >> >>> Run it a few times on Mac, but still not failing. >>> >>> openjdk version "1.8.0_222" >>> OpenJDK Runtime Environment (build 1.8.0_222-b10) >>> Eclipse OpenJ9 VM (build openj9-0.15.1, JRE 1.8.0 Mac OS X amd64-64-Bit >>> Compressed References 20190717_298 (JIT enabled, AOT enabled) >>> OpenJ9 - 0f66c6431 >>> OMR - ec782f26 >>> JCL - f147086df1 based on jdk8u222-b10) >>> >>> Andor >>> >>> >>> >>> > On 2019. Sep 10., at 20:38, Enrico Olivelli >>> wrote: >>> > >>> > I am using AdoptOpenJDK I see you are using Zulu, can you try with my >>> > version please? >>> > >>> > Enrico >>> > >>> > Il mar 10 set 2019, 19:38 Andor Molnar ha scritto: >>> > >>> >> This is running fine for me on both Java 8 and 11 on Debian 10. >>> >> openjdk version "1.8.0_222"OpenJDK Runtime Environment (Zulu >>> 8.40.0.25- >>> >> CA-linux64) (build 1.8.0_222-b10)OpenJDK 64-Bit Server VM (Zulu >>> >> 8.40.0.25-CA-linux64) (build 25.222-b10, mixed mode) >>> >> I run X509UtilTest multiple times, but never failed. >>> >> Andor >>> >> >>> >> -----Original Message-----From: Enrico Olivelli >> >Re >>> >> ply-To: dev@zookeeper.apache.orgTo: DevZooKeeper < >>> >> dev@zookeeper.apache.org>Subject: Re: Flaky test >>> >> X509UtilTest.testClientRenegotiationFails ?Date: Tue, 10 Sep 2019 >>> >> 18:40:29 +0200 >>> >> Sorry I missed to attach the error message:INFO] Running >>> >> org.apache.zookeeper.common.X509UtilTest[ERROR] Tests run: 336, >>> >> Failures: 0, Errors: 6, Skipped: 0, Time elapsed:12.394 s <<< FAILUR= E! >>> >> - in >>> >> >>> org.apache.zookeeper.common.X509UtilTest[ERROR]testClientRenegotiationF >>> >> ails[0](org.apache.zookeeper.common.X509UtilTest) Time elapsed: 0.43= 7 >>> >> s <<< ERROR!java.lang.Exception: Unexpected >>> >> exception,expected >>> >> >>> butwasatorg.apache.zookeeper.common.X509UtilT >>> >> est.testClientRenegotiationFails(X509UtilTest.java:579) >>> >> >>> [ERROR]testClientRenegotiationFails[1](org.apache.zookeeper.common.X509 >>> >> UtilTest) Time elapsed: 0.065 s <<< ERROR!java.lang.Exception: >>> >> Unexpected exception,expected >>> >> >>> butwasatorg.apache.zookeeper.common.X509UtilT >>> >> est.testClientRenegotiationFails(X509UtilTest.java:579) >>> >> >>> [ERROR]testClientRenegotiationFails[2](org.apache.zookeeper.common.X509 >>> >> UtilTest) Time elapsed: 0.071 s <<< ERROR!java.lang.Exception: >>> >> Unexpected exception,expected >>> >> >>> butwasatorg.apache.zookeeper.common.X509UtilT >>> >> est.testClientRenegotiationFails(X509UtilTest.java:579) >>> >> >>> [ERROR]testClientRenegotiationFails[4](org.apache.zookeeper.common.X509 >>> >> UtilTest) Time elapsed: 0.052 s <<< ERROR!java.lang.Exception: >>> >> Unexpected exception,expected >>> >> >>> butwasatorg.apache.zookeeper.common.X509UtilT >>> >> est.testClientRenegotiationFails(X509UtilTest.java:579) >>> >> >>> [ERROR]testClientRenegotiationFails[5](org.apache.zookeeper.common.X509 >>> >> UtilTest) Time elapsed: 0.058 s <<< ERROR!java.lang.Exception: >>> >> Unexpected exception,expected >>> >> >>> butwasatorg.apache.zookeeper.common.X509UtilT >>> >> est.testClientRenegotiationFails(X509UtilTest.java:579) >>> >> >>> [ERROR]testClientRenegotiationFails[7](org.apache.zookeeper.common.X509 >>> >> UtilTest) Time elapsed: 0.052 s <<< ERROR!java.lang.Exception: >>> >> Unexpected exception,expected >>> >> >>> butwasatorg.apache.zookeeper.common.X509UtilT >>> >> est.testClientRenegotiationFails(X509UtilTest.java:579) >>> >> >>> >> It is related to some combinations of the parametrized testI will >>> debug >>> >> as soon as I have cycles >>> >> Enrico >>> >> Il giorno mar 10 set 2019 alle ore 17:32 Andor Molnar < >>> andor@apache.org >>> >>> hascritto: >>> >>> What is the error message exactly? >>> >>> I don=E2=80=99t see this test failing on any of 3.5 builds here: >>> >>> https://builds.apache.org/view/S-Z/view/ZooKeeper/ >>> >>> >>> >>> Neither in the flaky test report: >>> >>> >>> >> >>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-Find-Fl= aky-Tests/lastSuccessfulBuild/artifact/report.html >>> >>> >>> >>> Andor >>> >>> >>> >>> >>> >>>> On 2019. Sep 9., at 21:54, Enrico Olivelli >>> >>>> wrote: >>> >>>> Hi,I am testing on branch-3.5.6, I see that this test is very flak= y >>> >>>> on JDK8(1.8.0_222 on Linux) >>> >>>> X509UtilTest.testClientRenegotiationFails >>> >>>> I see the test passing consistently on JDK12 >>> >>>> does anyone ever see this kind of problem ? >>> >>>> I am investigating, but any help will be very appreciated >>> >>>> Enrico >>> >> >>> >>> --000000000000f654cf05924df126--