From dev-return-82406-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Aug 14 11:21:09 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B2DFE1802C7 for ; Wed, 14 Aug 2019 13:21:08 +0200 (CEST) Received: (qmail 81611 invoked by uid 500); 14 Aug 2019 11:21:08 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 81597 invoked by uid 99); 14 Aug 2019 11:21:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Aug 2019 11:21:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 09644C02EB for ; Wed, 14 Aug 2019 11:21:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.001 X-Spam-Level: ** X-Spam-Status: No, score=2.001 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=limecraft-com.20150623.gappssmtp.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id WZ8fTjDg7I8Q for ; Wed, 14 Aug 2019 11:21:04 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::92f; helo=mail-ua1-x92f.google.com; envelope-from=koen.degroote@limecraft.com; receiver= Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [IPv6:2607:f8b0:4864:20::92f]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id E4F197D3FB for ; Wed, 14 Aug 2019 11:21:03 +0000 (UTC) Received: by mail-ua1-x92f.google.com with SMTP id g13so622741uap.5 for ; Wed, 14 Aug 2019 04:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=limecraft-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=Ek9mqaX3xjAB9DdLNPNr3CRJ2w8vY7SsFSOYsFL66zg=; b=vodU5U5KWsuMR2rBJau5WAbukYBmFQhIsDfo7cqDiLobPjG3IQ+FrHRun2iBrCm2gB Z9UeHtMWzYLLjPT0dhDO9pLOqKf8DUsz210Kg+oEdvD75pEyPzaSNuEfvDVzn1AE6A7r dW1Bqmdv6g8NhR6VrZ9pSLlXae4OdzMmksO1CI+hTVaaazHqkDPYcT4+6Xgq2vtUcqFo L9l4t8+P2QsN08gEftEZBBACLTa8R1efDmmphx49uGs7NGvOgPg+OVIxDQ3P1+fpjlKw 7m257rl2c5RXTPQ5qGjrPJttSNmH6tR9c2jfBNwvK6gqNT1CqldGaT0cq6xFnJgdU4w8 vwsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Ek9mqaX3xjAB9DdLNPNr3CRJ2w8vY7SsFSOYsFL66zg=; b=g2S9hcfsE7QOPI3iek0vyI/McqiM88C9mYifE/OroHjS4oYcvxG3iVJNaKfailiEbJ PwBtdTOTZFSYsUNwuA8aIy290BymMyMNnF/PwOq+0d/M8+VO8ZUCCaUAXxi9qJ4T4HMO vzSxq2keryz13pGjqf2vzz1ye2kEdsI+UbVcq4Us/phvzDnV0yqfkiazYzs1OJ2RlQFw Kd46sIZT85jWp88GYI8H4+tmIDpcTSdJ2U/hWgLbDPm38dqNnSXNmPyw+yml40odPyen JQPgEBLTPNQs7Lh97DH/cq9FawEB00WPyHnqbTtWsQXEO9Yw4A3Z5sFJPfB499V9e/cp M/hw== X-Gm-Message-State: APjAAAV7d5fTVNVQJdZhrlZ98mjrfKyPfChuVoeKzwuxsHi3U7zN24W4 A2PFvacL0BZEBY9mHDM2G50RICMMF54In8kRjKqJVvkLQhtnFg== X-Google-Smtp-Source: APXvYqwbZGMuj9gX2wivqxYms4rfdR2uj7K1M4zxSdSSXgUTe4r9zj2CiA5zYFY+EDKTUb+7QrlEbAQBEyS70jMk9fM= X-Received: by 2002:ab0:1843:: with SMTP id j3mr1316640uag.83.1565781657179; Wed, 14 Aug 2019 04:20:57 -0700 (PDT) MIME-Version: 1.0 From: Koen De Groote Date: Wed, 14 Aug 2019 13:20:21 +0200 Message-ID: Subject: Code to clean up transaction logs needs snapshots before it works? To: dev@zookeeper.apache.org Content-Type: multipart/alternative; boundary="00000000000078ed60059011f3fe" --00000000000078ed60059011f3fe Content-Type: text/plain; charset="UTF-8" Greetings all. I was debugging something an ran into this bit of code: https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/PurgeTxnLog.java#L81 If I understand it correctly, it seems that this means log.xxxxx files will only get deleted if there's a snapshot. Which is troublesome, as my dataDir is filling up with log files but not a single snapshot in sight. 1: Is this correct behavior? Both the logic of needing a snapshot and the fact that not snapshots are being generated? 2: While not having a fix for this, what would be useful to know is: can these log files be freely deleted? Or does the most recent one need to be kept, or how does it go with this files? I thought that running "bin/zkCleanup.sh /data -n 3" would clean up both the snapshots and the logs, but it appears that if there are not snapshots, the logs aren't cleaned either. What are my options here? Kind regards, Koen De Groote --00000000000078ed60059011f3fe--