From dev-return-81981-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Jul 16 11:59:48 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0E50E18064E for ; Tue, 16 Jul 2019 13:59:47 +0200 (CEST) Received: (qmail 14629 invoked by uid 500); 16 Jul 2019 11:59:47 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 14617 invoked by uid 99); 16 Jul 2019 11:59:47 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.159) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jul 2019 11:59:47 +0000 Received: from andors-macbook-pro.local (unknown [185.63.45.212]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id C48C68234 for ; Tue, 16 Jul 2019 11:59:41 +0000 (UTC) From: Andor Molnar Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: Intellij Idea warning as error with -Xdoclint Date: Tue, 16 Jul 2019 13:59:40 +0200 References: <880A465D-340D-4691-BAE8-D43E7003290F@apache.org> <40A95E72-2B3C-492B-8258-DBE7F1783AAE@apache.org> To: DevZooKeeper In-Reply-To: Message-Id: <2A670E6F-781C-4A9B-B40E-08FC91BEDE82@apache.org> X-Mailer: Apple Mail (2.3445.104.11) Idea cannot build ZooKeeper out-of-the-box. Here=E2=80=99s the error = message when trying to build zookeeper-server: = /Users/andormolnar/git/my-zookeeper/zookeeper-server/src/main/java/org/apa= che/zookeeper/server/command/StatCommand.java Warning:(19, 1) java: documentation comment not expected here Warning:(33, 8) java: no comment Warning:(34, 33) java: no comment Warning:(36, 17) java: no comment Warning:(37, 12) java: no comment Error:java: warnings found and -Werror specified There=E2=80=99re lots of others, I just picked StatCommand.java as an = example. Idea is running the standard Javac compiler with the arguments imported = from Maven settings: javac -Werror -Xlint:deprecation -Xlint:unchecked -Xdoclint = -Xpkginfo:always thanks, Andor > On 2019. Jul 16., at 13:37, Enrico Olivelli = wrote: >=20 > Il giorno mar 16 lug 2019 alle ore 07:44 Andor Molnar = ha > scritto: >=20 >> Yes, my main concern is: why does the maven succeed, if we're still >> having javadoc issues? >>=20 >=20 > if I run in zookeeper-server this command I can't find any WARNING or = ERROR > mvn javadoc:javadoc >=20 > only this ignorable one (I think) > INFO] --- maven-javadoc-plugin:3.0.1:javadoc (default-cli) @ zookeeper = --- > [ERROR] Error fetching link: > = /home/diennea.lan/enrico.olivelli/dev/zookeeper/zookeeper-jute/target/site= /apidocs/package-list. > Ignored it. >=20 > and javadocs are generated correctly >=20 > Does Idea fail the build ? do you have logs to share ? (I don't have = Idea, > I am using NetBeans that apparently runs maven from the command line = when > building) >=20 > Enrico >=20 >=20 >=20 >>=20 >> Andor >>=20 >>=20 >> -----Original Message----- >> From: Enrico Olivelli >> Reply-To: dev@zookeeper.apache.org >> To: dev@zookeeper.apache.org >> Subject: Re: Intellij Idea warning as error with -Xdoclint >> Date: Mon, 15 Jul 2019 21:58:09 +0200 >>=20 >> Il lun 15 lug 2019, 13:53 Andor Molnar < >> andor@apache.org >>> ha scritto: >>=20 >>> Hi Enrico, >>>=20 >>> This is still an issue for me in IDEA: >>>=20 >>> Javadoc problems found in zookeeper-jute and zookeeper-server >>> projects, so >>> the build eventually fails. Strange thing is that running maven from >>> command line doesn=E2=80=99t show any warning nor error. >>>=20 >>> =46rom javac params -Werror and -Xdoclint I think IDEA=E2=80=99s = behaviour is >>> correct. >>>=20 >>> Most warning messages in IDEA are about missing javadoc comments, so >>> changing it to "-Xdoclint:-missing=E2=80=9D solves the problem. >>>=20 >>=20 >> I can try to understand better. >> If I understand correctly your point is that apparently Idea is = working >> as >> expected but Maven not and this is not good because CI runs with = Maven. >>=20 >> I will be back with news. >> Hopefully we can fix javadocs and have a reliable way to detect = issues >> on >> docs on CI/precommit/nightly >>=20 >> Enrico >>=20 >>=20 >>> Regards, >>> Andor >>>=20 >>>=20 >>>=20 >>>=20 >>>> On 2019. Jun 20., at 20:28, Andor Molnar < >>>> andor@apache.org >>>>> wrote: >>>>=20 >>>> Done. #983 merged, problem gone. >>>> Thanks maoling! >>>>=20 >>>> Andor >>>>=20 >>>>=20 >>>>=20 >>>>> On 2019. Jun 20., at 15:43, maoling < >>>>> maoling199210191@sina.com >>>>>> wrote: >>>>>=20 >>>>> I also noticed this when running UT with IDEA.may we can merge >>>>> this PR: >>>>> https://github.com/apache/zookeeper/pull/988 >>>>>=20 >>>>> Or this one: >>>>> https://github.com/apache/zookeeper/pull/983 >>>>> to remove >>>=20 >>> that warning. >>>>> =E5=8F=91=E9=80=81=E8=87=AA Windows 10 =E7=89=88=E9=82=AE=E4=BB=B6=E5= =BA=94=E7=94=A8 >>>>>=20 >>>>> =E5=8F=91=E4=BB=B6=E4=BA=BA: Andor Molnar >>>>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2019=E5=B9=B46=E6=9C=8820=E6=97= =A5 5:46 >>>>> =E6=94=B6=E4=BB=B6=E4=BA=BA: DevZooKeeper >>>>> =E4=B8=BB=E9=A2=98: Intellij Idea warning as error with -Xdoclint >>>>>=20 >>>>>=20 >>>>> Hi Enrico, >>>>>=20 >>>>> I have the following error message in Idea since -Xdoclint is >>>>> enabled >>>=20 >>> in the main pom.xml file: >>>>>=20 >>>=20 >>> /Users/andormolnar/git/my-zookeeper/zookeeper- >>> jute/src/main/java/org/apache/jute/Utils.java >>>>> Error:(194, 15) java: @param name not found >>>>> Error:(231, 15) java: @param name not found >>>>>=20 >>>>> Strange that I don=E2=80=99t see the same warnings in console when >>>>> running =E2=80=98mvn >>>=20 >>> install=E2=80=99. >>>>> I confirm that removing =E2=80=9C-Xdoclint=E2=80=9D (or fixing = javadoc issues) >>>>> solves >>>=20 >>> the problem. >>>>> Andor >>>>>=20 >>>>>=20 >>>>>=20 >>>>>=20 >>>=20 >>>=20 >>=20 >>=20