From dev-return-81553-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Jun 3 08:48:50 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9100A18062F for ; Mon, 3 Jun 2019 10:48:50 +0200 (CEST) Received: (qmail 72828 invoked by uid 500); 3 Jun 2019 08:48:49 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 72809 invoked by uid 99); 3 Jun 2019 08:48:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Jun 2019 08:48:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 06CCBC0253 for ; Mon, 3 Jun 2019 08:48:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.801 X-Spam-Level: * X-Spam-Status: No, score=1.801 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=cloudera.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id N13o3ONW_wDh for ; Mon, 3 Jun 2019 08:48:46 +0000 (UTC) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4AF865F195 for ; Mon, 3 Jun 2019 08:48:45 +0000 (UTC) Received: by mail-pl1-f170.google.com with SMTP id p1so6716891plo.2 for ; Mon, 03 Jun 2019 01:48:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=HC+X+cgJkuolwkIx0n7fdOl5vS46OfakMV8iza1NLaw=; b=GfsridcTcWp4Hb8opF1SJ8GFz4/qK9j6RWjasN5j2J6G5Lf38rbsR/YXfKrUMrSZpR xHdAZYuvyReRFYdyifo7OIc9NZb626FXvTHHDxktJIoq3VcoTY3IC5TE0XB3burTylN8 Pf2cXX8W/j8wVbWndnswaaf/s9VjlgobgenbDzJL0H6Eec6JY9n7Bt6bqWZgc5RjjJVZ Ub35yDvu83AySBGWmkxhVOE74ffCi/FFQMwy/6UnJxXA6HUGP0yEr7NfjWS80ltksqio X9N62phfngWy7kGJ5OyPx5sNG70bt6CmSsozmnZhe5SM6OCdZFpPpdiUVAbxzAyWXuyJ oVzw== X-Gm-Message-State: APjAAAU+OL9Bpna5jd6Ba7oi22hH8eaX6ds35q34Uqcn9OhQHfhGjzA8 b00PgpU+nlrKfMAPW4picQ++Kvs5otImQ8s//gPoHyJq X-Google-Smtp-Source: APXvYqwTVNZxohtYidIjwGzg4i3GGiSNOqV+alUGw/T8cDBUL1/BhqsEZ6DNfdLLmM9CXxTL2RFS7OdwTq34ppAcx0c= X-Received: by 2002:a17:902:7d86:: with SMTP id a6mr3948525plm.199.1559551717884; Mon, 03 Jun 2019 01:48:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Norbert Kalmar Date: Mon, 3 Jun 2019 10:48:21 +0200 Message-ID: Subject: Re: Dropping ANT precommit script - last stept To: dev@zookeeper.apache.org Content-Type: multipart/alternative; boundary="0000000000002763d7058a676ec4" --0000000000002763d7058a676ec4 Content-Type: text/plain; charset="UTF-8" Hi Enrico, Thanks for looking into this. I also agree on the points to be dropped. Patrick has a valid point on the contrib tests though. (Maybe a vote on dropping some contrib projects first? :) ) I'd also like to add I get a lot of javadoc warnings on maven, I'm not sure why Ant doesn't complain, guess different configuration? Regards, Norbert On Fri, May 31, 2019 at 6:04 PM Patrick Hunt wrote: > Sounds reasonable. Have you looked at what Yetus provides? iiuc a number of > the hadoop ecosystem projects use it to provide base/consistent experience > wrt the build. Now that we're on Maven perhaps we should re-evaluate? > > re #8 - I don't think we should compromise given contrib is still not > decided. > > Patrick > > On Fri, May 31, 2019 at 8:39 AM Enrico Olivelli > wrote: > > > Hi, > > you can find here (1) the current ANT-based precommit script that runs > > againsts every Github Pull Request . > > > > These are the steps of the script and how we are doing the same in Maven: > > 1) check for @author tags -> handled with maven-checkstyle-plugin > > 2) Check for new tests in the patch -> not handled with maven > > 3) check javadoc warnings -> not handled with maven (we should add > > -Xdoclint in Maven) > > 4) check java compilation for warnings -> handled with -Werror > > -Xlint:deprecation -Xlint:unchecked (this is slightly different, in ANT > we > > have a generic -Xlint and we were counting for the number of warnings) > > 5) check for "releaseaudit" -> handled with "Apache Rat Plugin" in maven > > 6) check "findbugs" -> handled with "spotbugs" with maven > > 7) run "tests" -> handle with maven default build "verify" > > 8) run "contrib tests" -> not handled with maven > > 9) add JIRA comment -> not handled with maven (not needed IMHO, we have > > github PR status lines) > > > > My questions to the community: > > - I would like to drop 2), "check for new tests": I think it gives no so > > much value, and it is tricky to reimplement, but I can do > > - I would like to drop 8) "run contrib tests": there is an open > discussion > > about dropping "contrib" at all > > - I would like to drop 9) -> add jira comment: We already have a better > > workflow with github, no need to spam JIRA. I can see a little value in > > having some track in JIRA that "the patch was good", but I don't think it > > is worth to continue to put JIRA credentials on jenkins (from a security > > perspective) > > > > Please take a look and give your opinion, if no one objects and some > > committer supports my changes we will be able to drop ANT precommit soon > > > > Regards > > > > Enrico > > > > [1] > > > > > https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/test/resources/test-github-pr.sh > > > --0000000000002763d7058a676ec4--