From dev-return-81672-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Jun 20 18:06:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 699DE180670 for ; Thu, 20 Jun 2019 20:06:05 +0200 (CEST) Received: (qmail 96251 invoked by uid 500); 20 Jun 2019 18:06:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 96239 invoked by uid 99); 20 Jun 2019 18:06:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Jun 2019 18:06:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D1095180C3E for ; Thu, 20 Jun 2019 18:06:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.801 X-Spam-Level: * X-Spam-Status: No, score=1.801 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id QoGZXVIx8QPN for ; Thu, 20 Jun 2019 18:06:01 +0000 (UTC) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id AE0675F39D for ; Thu, 20 Jun 2019 18:06:00 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id a9so3097990lff.7 for ; Thu, 20 Jun 2019 11:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=gzQiqEbfN8eeSPb/9FUJKLWLCrEdZvPtMqukJgTPXHM=; b=uCDuRY51+VFajq5VPUXxCZvhqV8Egvmk4+OAjqA5b2l+tQp7OcV37SW7VvmflCHhyU h7s14B1cyB76Od7HX9NACIn+K/R8WqX651R0NF+ZVRAz1iSVHDCQGHblcy59+2aTKNx2 BDgYQEegIY3pA9npe/6ss6CVlwoiogjwTGsn0JN9QwR0vKowsUCEcUp3EiBx2/pgaWdQ Rh3Aq2CkrS0vbES0j/r8lqThR8Dp0y7ann1/+3B6sBABLYmlNcGxkAmR1prwPZDtM4Q2 lq+a/DldluEfJZ9uDMpQW5RHWWQLBq5XzoiwLMuswmHfO449KQAzXkPoHuLHW4uxs3M5 SqNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=gzQiqEbfN8eeSPb/9FUJKLWLCrEdZvPtMqukJgTPXHM=; b=oU3rBL2VgfoCKleJtp8LuJH6cK2aEEFel2WomxtKdcTTQLXZ+O092zQ/W+mOw32/Hw lolBODjnCtPMzZ8OcannyA4r3kGfOI8dQWbXMLqvpjr8kdMjnKI2Yt1dlL2uVHgL1S/Z 0h03HGM6iz0iDjgFHp2gpVr08vnA2bTmCkBa9Ewcsra5ZPpcggsoipItYkXHB7y62P4h /fXj27b9Usxx8XHfajTEm1az1XWAu8jbHayxBfVBQ3QE4w9mGLyDn0Fil/s+oo2IonfM COZbOIlE8NF/Xl8RjHKVsq22I5Wyj28nLOHsXM397swyMMzKSpsiBxTSncLUkAdiGjzz O58A== X-Gm-Message-State: APjAAAXuMTUGmMnURSpWflTyxQY844Yy9YckhaJIBm5eoIxfxYAYIoFL gCH76hzEfUXhgK+GwF9ta74xh6KIYwcr7MUHbSns8g== X-Google-Smtp-Source: APXvYqwLx/S1GiFmntzGmDrzFsuntO8HYHVpybLlki4yeBcUJWHsKfvWg5ns9bF4EH9jMRC+9/1MUkBWh7Cs6vojKA8= X-Received: by 2002:a19:8c08:: with SMTP id o8mr46823391lfd.57.1561053954362; Thu, 20 Jun 2019 11:05:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Enrico Olivelli Date: Thu, 20 Jun 2019 20:05:42 +0200 Message-ID: Subject: Re: [DISCUSS] Is it time to remove Apache Ant from ZooKeeper? To: DevZooKeeper Content-Type: multipart/alternative; boundary="0000000000006cd2ee058bc532db" --0000000000006cd2ee058bc532db Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Il giorno mer 19 giu 2019 alle ore 08:14 Patrick Hunt ha scritto: > On Tue, Jun 18, 2019 at 11:02 PM Enrico Olivelli > wrote: > > > Il mer 19 giu 2019, 06:38 Patrick Hunt ha scritto: > > > > > What's the current status on maven replacing ant? Is there a current > > > summary somewhere? Perhaps someone could create a wiki page to track > the > > > status across the three branches and plans/remainder for each? > > > > > > > Good idea! > > I will do. > > > > > > > > > > > I noticed today that even with the "full-build" profile it doesn't lo= ok > > > like maven is building the c client (did I miss something?), > > > > > > We are building the C client on travis in precommit > > > > mvn clean install -Pfull-build > > > > > Hm, something is odd/broken then - looking back through my history I ran > > $ mvn clean install -DskipTests -Pfull-build > > the "configure" script was run but no make was run. > > I would expect that a full-build install would generate the c client even > if testing was skipped. Any ideas what's up there? > I am working on a fix. I will send a patch soon. Enrico > > Patrick > > > > > > even though > > > ant compile-native is. Stuff like this we can't lose and will need to > be > > > working before we can fully migrate. > > > > > > > Sure > > > > > > > > Thanks, > > > > > > Patrick > > > > > > > > > On Thu, May 23, 2019 at 9:37 AM Fangmin Lv > wrote: > > > > > > > We=E2=80=99re still using ant as a build block internally on 3.6, w= orking on > > > moving > > > > to maven, will change soon, so it=E2=80=99s fine to remove ant. > > > > > > > > Fangmin > > > > > > > > On Thu, May 23, 2019 at 2:55 AM Norbert Kalmar > > > > > > > > wrote: > > > > > > > > > 3.4 will remain on Ant, we have decided/voted/discussed (not sure > > which > > > > was > > > > > it :) ) that not long ago. Even maven is faulty on 3.4 ... > > > > > So only 3.5 and master is on the vote. > > > > > > > > > > Thanks Enrico for working on this! > > > > > > > > > > On Wed, May 22, 2019 at 7:06 PM Enrico Olivelli < > eolivelli@gmail.com > > > > > > > > wrote: > > > > > > > > > > > Il mer 22 mag 2019, 12:17 Norbert Kalmar > > > > > > > > > > > > ha > > > > > > scritto: > > > > > > > > > > > > > And "release with Ant" I mean the 3.5.5 src tarball containin= g > > the > > > > Ant > > > > > > > script as well, so people have the option to build it with An= t. > > > > > > > > > > > > > > > > > > > IMHO this is not a big deal. The release has been performed wit= h > > > Maven > > > > > and > > > > > > the resulting artifacts are different from the Ant results. > > > > > > But I don't have a strong opinion here > > > > > > > > > > > > Enrico > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, May 22, 2019 at 12:13 PM Norbert Kalmar < > > > > nkalmar@cloudera.com> > > > > > > > wrote: > > > > > > > > > > > > > > > Sorry, I was too quick to reply, didn't think it through. > > > > > > > > We did release the first stable 3.5 ZooKeeper with Ant, so = I > > > guess > > > > we > > > > > > > will > > > > > > > > need to support on 3.5.x > > > > > > > > > > > > > > > > On Wed, May 22, 2019 at 12:12 PM Norbert Kalmar < > > > > > nkalmar@cloudera.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > >> +1, let's remove it. I would say lets remove Ant from 3.5 > > branch > > > > as > > > > > > > well. > > > > > > > >> Having 2 build system is just a huge source of confusion, > > > > especially > > > > > > > that > > > > > > > >> we have dependency versions in two different locations. > > > > > > > >> > > > > > > > >> Regards, > > > > > > > >> Norbert > > > > > > > >> > > > > > > > >> On Wed, May 22, 2019 at 9:44 AM Tamas Penzes > > > > > > > > > > > > > > >> wrote: > > > > > > > >> > > > > > > > >>> Hi All, > > > > > > > >>> > > > > > > > >>> Not that long ago we did have a discuss about removing An= t > > from > > > > > > > >>> ZooKeeper. > > > > > > > >>> I'd like to restart that discussion since ZooKeeper 3.5.5 > is > > GA > > > > and > > > > > > it > > > > > > > >>> was > > > > > > > >>> built and released with Maven. > > > > > > > >>> Is it time to remove Ant from the master branch? > > > > > > > >>> > > > > > > > >>> That would mean that Ant would not be available from the > next > > > > minor > > > > > > > >>> version, which is probably 3.6.0. > > > > > > > >>> > > > > > > > >>> Please share your opinion. > > > > > > > >>> > > > > > > > >>> Thanks, Tamaas > > > > > > > >>> > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > --0000000000006cd2ee058bc532db--