From dev-return-81617-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Jun 14 05:44:53 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E7ABD18062F for ; Fri, 14 Jun 2019 07:44:52 +0200 (CEST) Received: (qmail 6695 invoked by uid 500); 14 Jun 2019 05:44:52 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 6681 invoked by uid 99); 14 Jun 2019 05:44:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jun 2019 05:44:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 06200180FB0 for ; Fri, 14 Jun 2019 05:44:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.799 X-Spam-Level: * X-Spam-Status: No, score=1.799 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id A6jXlzS0m2xj for ; Fri, 14 Jun 2019 05:44:48 +0000 (UTC) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 66DB35F382 for ; Fri, 14 Jun 2019 05:44:47 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id s21so1052776lji.8 for ; Thu, 13 Jun 2019 22:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=lKaSUA8VHGFC+D29/kpbpREa2DbjSvLYBCVzqjnCjaM=; b=XiqqEjl3dutSLUDL+t16rDBxXgDIAEm3Qfq8GHhIMWRz62dP1WXAm9N/S4Iq+DYcgv IodPQCu9UbDpKvkrLI5TZKG16SOzQ1Byab1qPM3JMnJOkx8Z9yHaFbV2wqPKtIORLjEu LSGMvSVamnpaXYOh/w5Wp9qBjtRZtToHIS919s6469KWeopLIAGo0MzuMGZOOjZA8h9q xSZR+Cu4ui5hnw25/0su3eSL4UHBgweHDNFbuYVgz16L1lKSbYWriD61pMnzReEvI+iD wgpkOlgPHoGQxxxtUk12iXy9dBPr+U43DWTqdIx/3u5KMfy01JcU1kSIYbIxGQx7ReCN PYPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=lKaSUA8VHGFC+D29/kpbpREa2DbjSvLYBCVzqjnCjaM=; b=I1nlZk9hqMib48uni4bTS9l6xccSzjOCMnh3TriXyi6PQlGML/k9/Wsa+PioPK+oLE K4dJuOtIPU2ZPMhcSX4wShCYVsoqaMLatSjGsszX7EtE+zge65m5ymCYfULV0Yl2lAW6 QqDcIR//IrJccTcD1l33tR1h7usuJNE2iKOAv0jwp7vhwjUaN/3vCR2MzHCp8/pEGA+L k2o+PGXRMTihvkgAcj7iWA4clV85/xR8CyRqHk/M9mkQd1xvjgs7dOCZYUARxc6PDXpN ESGG30OoDQavWzAMmuzMiizic7ybER4uq3mOB1ok6IMykf56rnhL9n9h3QWOOUxxpgMZ ksFw== X-Gm-Message-State: APjAAAXxwseH5YAzUiIvq4khz2mqrqKz2mDh7m7LjTcdK4eTVMaOTdfW 5q7pBDzxVWYrkNUPn2CYdWkDq6Ylt7wxs7R8qFrgYw== X-Google-Smtp-Source: APXvYqwOFqBwwhl1DSRzhZTd82tK5iS7r9pu7N2W3kt7spBT5vPCvoBDW6bXAnqLvoxxuO5pBv3w9tRyjgZuXdRGie4= X-Received: by 2002:a2e:898b:: with SMTP id c11mr2974264lji.241.1560491086324; Thu, 13 Jun 2019 22:44:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Enrico Olivelli Date: Fri, 14 Jun 2019 07:44:34 +0200 Message-ID: Subject: Re: PostCommit- CI job ? Where it is ? To: dev@zookeeper.apache.org Content-Type: multipart/alternative; boundary="000000000000e029cd058b4224ac" --000000000000e029cd058b4224ac Content-Type: text/plain; charset="UTF-8" Il ven 14 giu 2019, 00:50 Michael Han ha scritto: > I see now. This was a job I set up long time ago for my own testing purpose > only; it was not intended to be part of official commit workflow. I am not > sure how this job becomes the official post commit job though. If we have > daily builds (do we) - then probably we don't need this. Though keep it > does not hurt, either. Actually it is the last tool that is using ant and it is the only one that needs jira credentials. Personally I would drop it. Enrico I have no strong preference one way or the other. > > > On Wed, Jun 12, 2019 at 1:50 AM Andor Molnar > wrote: > > > It might give some additional feedback to the committer/contributor > whether > > the patch has been successfully integrated into the target branch. We've > > seen issues when the merge build was outdated, showing green light on the > > pull request and the commit eventually broke master after merging. > > > > I'm not 100% sure we need it, maybe other folks can give some more color > to > > this. > > > > Btw. do we already have a View in jenkins for Maven builds like this one > > for Ant: https://builds.apache.org/view/S-Z/view/ZooKeeper/ > > > > Andor > > > > > > > > On Wed, Jun 12, 2019 at 10:33 AM Enrico Olivelli > > wrote: > > > > > Michael > > > it seems that the job is trying to send emails to you at > > lhan@twitter.com > > > but there is a typo. > > > > > > Do we still need this job? > > > As we are dropping ANT we have to migrate it, but I don't find much > value > > > as we are already performing daily builds and precommits. > > > Having such comment in jira is not so important > > > > > > Enrico > > > > > > Enrico > > > > > > Il mer 12 giu 2019, 10:04 Enrico Olivelli ha > > > scritto: > > > > > > > Self answered from the message on jira... > > > > > > > > It is zookeeper-trunk-single-thread > > > > > > > > Thanks Michael > > > > > > > > Enrico > > > > > > > > SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread > #388 > > > > (See [ > https://builds.apache.org/job/Zookeeper-trunk-single-thread/388/ > > ]) > > > > > > > > ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move > remaining > > > > (nkalmar: rev 6af151a7e44760c33165e58d3b33a4d2760283a4) > > > > * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/ > > > > MetricsContext.java > > > > * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ > > > > command/MonitorCommand.java > > > > * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ > > > > > > > > > > > > > > > > Il mer 12 giu 2019, 02:00 Michael Han ha scritto: > > > > > > > >> Hi Enrico, > > > >> > > > >> I don't think it's a post commit job that adds the "Issue resolved > by > > > pull > > > >> request...." comment (if this is the comment you were referring > to.). > > > This > > > >> was added by the merge script through JIRA api. > > > >> > > > >> On Mon, Jun 10, 2019 at 1:34 PM Enrico Olivelli < > eolivelli@gmail.com> > > > >> wrote: > > > >> > > > >> > Hi ZooKeepers, > > > >> > I am looking for the Post-Commit job, the one that adds that JIRA > > > >> comment > > > >> > after we merge a PR. > > > >> > > > > >> > I would like to understand it and decide whether to drop it or to > > move > > > >> it > > > >> > to Maven. > > > >> > Personally I don't find much value in that task. > > > >> > > > > >> > This is my search [1] (I hope that the link works for you) > > > >> > > > > >> > Enrico > > > >> > > > > >> > [1] > > > >> > > > > >> > > > > >> > > > > > > https://builds.apache.org/job/Zookeeper-trunk-single-thread/search/?q=zookeeper&Jenkins-Crumb=1e1a1d3bbc6a541e903422747a16c759 > > > >> > > > > >> > > > > > > > > > > --000000000000e029cd058b4224ac--