zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andor Molnar <an...@apache.org>
Subject Re: PostCommit- CI job ? Where it is ?
Date Sun, 16 Jun 2019 16:18:07 GMT
I created a new view for Maven builds:

https://builds.apache.org/view/S-Z/view/ZooKeeper-Maven/ <https://builds.apache.org/view/S-Z/view/ZooKeeper-Maven/>

Where are the rest?
Maybe I’m looking at the wrong place, but cannot find anything else.

Andor



> On 2019. Jun 14., at 9:39, Enrico Olivelli <eolivelli@gmail.com> wrote:
> 
> Il ven 14 giu 2019, 09:17 Andor Molnar <andor@cloudera.com.invalid> ha
> scritto:
> 
>> +1 for dropping it.
>> 
>> Enrico, have you created a Jenkins view which gathers all Maven based
>> builds?
>> 
> 
> No I don't. I am not an user of such views.
> Feel free to do it.
> 
> We should also drop a bunch of disabled jobs, like the one for solaris
> 
> We should create a wiki page with the description of every job
> 
> Enrico
> 
> 
>> Andor
>> 
>> 
>> 
>> On Fri, Jun 14, 2019 at 7:44 AM Enrico Olivelli <eolivelli@gmail.com>
>> wrote:
>> 
>>> Il ven 14 giu 2019, 00:50 Michael Han <hanm@apache.org> ha scritto:
>>> 
>>>> I see now. This was a job I set up long time ago for my own testing
>>> purpose
>>>> only; it was not intended to be part of official commit workflow. I am
>>> not
>>>> sure how this job becomes the official post commit job though. If we
>> have
>>>> daily builds (do we) - then probably we don't need this. Though keep it
>>>> does not hurt, either.
>>> 
>>> 
>>> Actually it is the last tool that is using ant and it is the only one
>> that
>>> needs jira credentials.
>>> 
>>> Personally I would drop it.
>>> 
>>> Enrico
>>> 
>>> 
>>> I have no strong preference one way or the other.
>>>> 
>>>> 
>>>> On Wed, Jun 12, 2019 at 1:50 AM Andor Molnar
>> <andor@cloudera.com.invalid
>>>> 
>>>> wrote:
>>>> 
>>>>> It might give some additional feedback to the committer/contributor
>>>> whether
>>>>> the patch has been successfully integrated into the target branch.
>>> We've
>>>>> seen issues when the merge build was outdated, showing green light on
>>> the
>>>>> pull request and the commit eventually broke master after merging.
>>>>> 
>>>>> I'm not 100% sure we need it, maybe other folks can give some more
>>> color
>>>> to
>>>>> this.
>>>>> 
>>>>> Btw. do we already have a View in jenkins for Maven builds like this
>>> one
>>>>> for Ant: https://builds.apache.org/view/S-Z/view/ZooKeeper/
>>>>> 
>>>>> Andor
>>>>> 
>>>>> 
>>>>> 
>>>>> On Wed, Jun 12, 2019 at 10:33 AM Enrico Olivelli <
>> eolivelli@gmail.com>
>>>>> wrote:
>>>>> 
>>>>>> Michael
>>>>>> it seems that the job is trying to send emails to you at
>>>>> lhan@twitter.com
>>>>>> but there is a typo.
>>>>>> 
>>>>>> Do we still need this job?
>>>>>> As we are dropping ANT we have to migrate it, but I don't find much
>>>> value
>>>>>> as we are already performing daily builds and precommits.
>>>>>> Having such comment in jira is not so important
>>>>>> 
>>>>>> Enrico
>>>>>> 
>>>>>> Enrico
>>>>>> 
>>>>>> Il mer 12 giu 2019, 10:04 Enrico Olivelli <eolivelli@gmail.com>
ha
>>>>>> scritto:
>>>>>> 
>>>>>>> Self answered from the message on jira...
>>>>>>> 
>>>>>>> It is zookeeper-trunk-single-thread
>>>>>>> 
>>>>>>> Thanks Michael
>>>>>>> 
>>>>>>> Enrico
>>>>>>> 
>>>>>>> SUCCESS: Integrated in Jenkins build
>> Zookeeper-trunk-single-thread
>>>> #388
>>>>>>> (See [
>>>> https://builds.apache.org/job/Zookeeper-trunk-single-thread/388/
>>>>> ])
>>>>>>> 
>>>>>>> ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move
>>>> remaining
>>>>>>> (nkalmar: rev 6af151a7e44760c33165e58d3b33a4d2760283a4)
>>>>>>> * (edit)
>>> zookeeper-server/src/main/java/org/apache/zookeeper/metrics/
>>>>>>> MetricsContext.java
>>>>>>> * (edit)
>>> zookeeper-server/src/main/java/org/apache/zookeeper/server/
>>>>>>> command/MonitorCommand.java
>>>>>>> * (edit)
>>> zookeeper-server/src/main/java/org/apache/zookeeper/server/
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> Il mer 12 giu 2019, 02:00 Michael Han <hanm@apache.org>
ha
>>> scritto:
>>>>>>> 
>>>>>>>> Hi Enrico,
>>>>>>>> 
>>>>>>>> I don't think it's a post commit job that adds the "Issue
>> resolved
>>>> by
>>>>>> pull
>>>>>>>> request...." comment (if this is the comment you were referring
>>>> to.).
>>>>>> This
>>>>>>>> was added by the merge script through JIRA api.
>>>>>>>> 
>>>>>>>> On Mon, Jun 10, 2019 at 1:34 PM Enrico Olivelli <
>>>> eolivelli@gmail.com>
>>>>>>>> wrote:
>>>>>>>> 
>>>>>>>>> Hi ZooKeepers,
>>>>>>>>> I am looking for the Post-Commit job, the one that adds
that
>>> JIRA
>>>>>>>> comment
>>>>>>>>> after we merge a PR.
>>>>>>>>> 
>>>>>>>>> I would like to understand it and decide whether to drop
it or
>>> to
>>>>> move
>>>>>>>> it
>>>>>>>>> to Maven.
>>>>>>>>> Personally I don't find much value in that task.
>>>>>>>>> 
>>>>>>>>> This is my search [1] (I hope that the link works for
you)
>>>>>>>>> 
>>>>>>>>> Enrico
>>>>>>>>> 
>>>>>>>>> [1]
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>>> 
>> https://builds.apache.org/job/Zookeeper-trunk-single-thread/search/?q=zookeeper&Jenkins-Crumb=1e1a1d3bbc6a541e903422747a16c759
>>>>>>>>> 
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>>> 
>> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message