From dev-return-81178-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon May 20 23:07:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 37A54180627 for ; Tue, 21 May 2019 01:07:05 +0200 (CEST) Received: (qmail 60098 invoked by uid 500); 20 May 2019 23:07:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 60087 invoked by uid 99); 20 May 2019 23:07:04 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 May 2019 23:07:04 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 76F04E0371 for ; Mon, 20 May 2019 23:07:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 351F220FEB for ; Mon, 20 May 2019 23:07:00 +0000 (UTC) Date: Mon, 20 May 2019 23:07:00 +0000 (UTC) From: "Brian Nixon (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3349?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16844371#comment-16844371 ]=20 Brian Nixon commented on ZOOKEEPER-3349: ---------------------------------------- This parameter is being used again as of ZOOKEEPER-3378. Nothing to do here= . > QuorumCnxManager socketTimeout unused > ------------------------------------- > > Key: ZOOKEEPER-3349 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3349 > Project: ZooKeeper > Issue Type: New Feature > Components: quorum > Affects Versions: 3.6.0 > Reporter: Brian Nixon > Priority: Trivial > Labels: pull-request-available > Time Spent: 2h 20m > Remaining Estimate: 0h > > QuorumCnxManager member variable 'socketTimeout' is not used anywhere in = the class. It's clear from the context that it should either be removed ent= irely or invoked in QuorumCnxManager::setSockOpts. Since the QuorumPeer syn= cLimit can be changed by jmx, I'm thinking that the former is the better so= lution. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)