From dev-return-80805-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed May 8 18:23:51 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AF81C180630 for ; Wed, 8 May 2019 20:23:50 +0200 (CEST) Received: (qmail 30845 invoked by uid 500); 8 May 2019 18:23:49 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 30811 invoked by uid 99); 8 May 2019 18:23:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 May 2019 18:23:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BF54F180CE3 for ; Wed, 8 May 2019 18:23:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.8 X-Spam-Level: * X-Spam-Status: No, score=1.8 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id gtYDtAbj0SHB for ; Wed, 8 May 2019 18:23:45 +0000 (UTC) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B428161276 for ; Wed, 8 May 2019 18:17:33 +0000 (UTC) Received: by mail-lf1-f43.google.com with SMTP id u27so14975763lfg.10 for ; Wed, 08 May 2019 11:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=RvsMyhwNu+94wsF5S9ICAw99eMT7BAs/HhSp81XBiek=; b=eWrO5OcGXozBLZDgsxfPy+vWzw66S6poaM5hnPeN43FKVq7YR7rp9ElCa7BkEoh/Kd +HT5UYqVmBJwCdWAwnABgqYaZi9djcm/lubbSsei6GVXs0Be85Afwbw1+M+JJTRIBRES jaOBxWAG/41cQ9Sgt0dXjnJijxSUPOn6nuuWW+og8b+8XyqvZ0CTZXpU5DEg5gE/OvTp kz2EJiAvf0qTpJEytoPsMka2/nrImOBKnCjbuQ27/G5/e7Q9VHO64FdTfN/OQErrSfCF quWExfG6SxIkqtKtnyw9OLPeKEfWql4C8a5SvDED11Y5Rn2H3y4Uz7JaN0gLqFE22Syy a+aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=RvsMyhwNu+94wsF5S9ICAw99eMT7BAs/HhSp81XBiek=; b=O51X6fBu3rJqqHZg67EoazhRZuY7py+59dLjabFP0jVAFYa0x+vT0XyXpGg87BkAW+ vXuJttyWNX8KmNgOY8/yfII3NOPCBZm8HGM+PnhoNw7AwJCRlZiVx7XrHAd7SjEgm7AZ k2dJRpszHZwhq/O4b7uqEG+HywtFC99KjlI5ZWv9aKPmX/V4ikOEHswWR/LqE7822vzU COQBxRbgfsmksuZ9N8LDCVTXobnm4g5+uCUJzjXv6k5JdYycSsRXgzZdTFdY2oErfqlu ZmW8uApXYefHKoYo/724B7A3rVilgS4LpUN2OLK/jk0awGPFp3yaZldfsHVrko7IRmPA TltQ== X-Gm-Message-State: APjAAAUO+TahYhlG1xAvsk21u0+Fp5pBRpQUG6mzPMUMtakp7MdUjDYu tbWMlO8rNKB7E97BVtxYvLIuhpslLHQ9R7UsWEtkMA== X-Google-Smtp-Source: APXvYqyMLQASKuxjYLzesR7IqUxxbV+k4soFklvuFCS1RHanBDfwi34rXEl5GmvtdCOq4QnaA1P17oBLEGxcQHjr1P4= X-Received: by 2002:ac2:4186:: with SMTP id z6mr8628214lfh.50.1557339451904; Wed, 08 May 2019 11:17:31 -0700 (PDT) MIME-Version: 1.0 References: <20190508122404.8F8A14E4@webmail.sinamail.sina.com.cn> In-Reply-To: From: Enrico Olivelli Date: Wed, 8 May 2019 20:17:19 +0200 Message-ID: Subject: Re: [Suggestion] Use Co-authored-by in commit messages To: DevZooKeeper Content-Type: multipart/alternative; boundary="000000000000d357b505886458fe" --000000000000d357b505886458fe Content-Type: text/plain; charset="UTF-8" Yes, it is a good idea to have a common practice for tracking the original author. IMHO this is up to the person who is picking up an old patch, it is his own responsibility. IIRC In Bookkeeper we keep the original author of the patch if the patch is a straight port from another private company fork with minimal changes. Having a Co-author is good from my side. I am not sure we can force it My 2cents Enrico Il mer 8 mag 2019, 19:31 Brian Nixon ha scritto: > +1 to the idea of multiple authors, particularly for rescued code > > -1 to including all reviewers in the commit proper, this information is > easily enough found from poking at the mail archive where "original author" > requires studying a ticket on jira > > awesome idea! > > > On Wed, May 8, 2019 at 6:32 AM Norbert Kalmar > > wrote: > > > Sorry everyone for the multiple emails... > > So, I get your suggestion now Maoling, sorry for the confusion. > > We already indicate the reviewer if it's from an apache email, as it > looks > > to me. (Doesn't have to be ZooKeeper committer). We should add external > > emails as well. > > > > So I just clarified this with Andor, looks like this is a manual entry > (the > > names/emails itself) during the commit (script). > > > > Let's hear what others think :) > > > > > > On Wed, May 8, 2019 at 3:24 PM Norbert Kalmar > > wrote: > > > > > Well, HBase does it for example, commits have a "Signed-off-by: ..." > > line. > > > > > > All right, votes on for co-author and signed-off-by :) > > > > > > > > > > > > On Wed, May 8, 2019 at 2:58 PM Norbert Kalmar > > > wrote: > > > > > >> Thanks Maoling, I also think encouraging code review as well is a good > > >> idea, but, unfortunately I have a "but" :) > > >> I see two issues with including reviewers in the commit message. > > >> First, I don't think there is a method to automate this, although I > > think > > >> the commit script the committers are using can be modified to include > > it. > > >> Otherwise doing manually would complicate merging PRs for committers. > > >> My other, bigger issue is that there is nothing to track this > > >> information. At least I am not aware of anything. What I mean is > Github > > >> tracks authors of the commits. But what would we use the reviewers > > >> information? If you just want to check reviewers for whatever reason, > > there > > >> is a filter for that already on github, in the Pull Request view. And > > this > > >> would also make the commit message more "bloated". > > >> > > >> I'm not saying we shouldn't do this (not a -1 from my side), I just > have > > >> my concerns mentioned above. > > >> > > >> Is there any Apache project doing this? Just out of curiosity. > > >> > > >> Regards, > > >> Norbert > > >> > > >> > > >> On Wed, May 8, 2019 at 2:34 PM Justin Ling Mao < > > maoling199210191@sina.com> > > >> wrote: > > >> > > >>> +1,A very good Suggestion.Thanks Norbert.I also suggest about the > > >>> sign-off of the Reviewers' name.For the incentive, if someone > > participate > > >>> in the review of PR, no matter whether he/she is a committer, we all > > need > > >>> include his/her name? > > >>> > > >>> ----- Original Message ----- > > >>> From: Norbert Kalmar > > >>> To: dev@zookeeper.apache.org > > >>> Subject: [Suggestion] Use Co-authored-by in commit messages > > >>> Date: 2019-05-08 17:36 > > >>> > > >>> Hi Devs, > > >>> I've got this idea from HBase. > > >>> So: when there is a patch that is abandoned by its original author > for > > >>> any > > >>> reason, and it can no longer be merged, someone comes by, and asks to > > >>> continue to work on it. Usually the reply is to use the change freely > > or > > >>> no > > >>> reply at all. Either way, what people end up doing is a new pull > > request, > > >>> and (correct me if I'm wrong) we do not have a standardized method > how > > to > > >>> indicate, or even to indicate at all the original author. > > >>> My proposal is to use github's feature of Co-author, which is a way > of > > >>> attributing multiple authors of a given commit. See more details > here: > > >>> > > >>> > > > https://help.github.com/en/articles/creating-a-commit-with-multiple-authors > > >>> I wouldn't think this needs to be forced or anything on future PRs, > but > > >>> it's a nice thing to have. And if someone sees an old patch, this > could > > >>> give more incentive to continue to work on it, knowing there's a > > >>> guideline > > >>> in the HowToContribute guide to credit him/her. > > >>> I can update the guide at > > >>> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute > > if > > >>> the reception is positive. > > >>> Regards, > > >>> Norbert > > >>> > > >> > > > --000000000000d357b505886458fe--