From dev-return-80896-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sat May 11 00:33:00 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 545F2180763 for ; Sat, 11 May 2019 02:33:00 +0200 (CEST) Received: (qmail 98864 invoked by uid 500); 11 May 2019 00:32:59 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 98848 invoked by uid 99); 11 May 2019 00:32:59 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 May 2019 00:32:59 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] [zookeeper] lvfangmin commented on a change in pull request #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider Message-ID: <155753477436.3904.8927907733788842101.gitbox@gitbox.apache.org> Date: Sat, 11 May 2019 00:32:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit lvfangmin commented on a change in pull request #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#discussion_r283073478 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ########## @@ -1383,4 +1392,85 @@ public void setResponseCachingEnabled(boolean isEnabled) { public ResponseCache getReadResponseCache() { return isResponseCachingEnabled ? readResponseCache : null; } + + protected void registerMetrics() { Review comment: That makes sense to me, are we seeing this pattern often, should we define an interface for these methods? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services