From dev-return-80786-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed May 8 05:29:41 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1FC4E180630 for ; Wed, 8 May 2019 07:29:41 +0200 (CEST) Received: (qmail 83664 invoked by uid 500); 8 May 2019 05:29:39 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 83447 invoked by uid 99); 8 May 2019 05:29:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 May 2019 05:29:39 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] [zookeeper] eolivelli commented on a change in pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics Message-ID: <155729337931.7920.6847567809864239232.gitbox@gitbox.apache.org> Date: Wed, 08 May 2019 05:29:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit eolivelli commented on a change in pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#discussion_r281917699 ########## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerMetricsTest.java ########## @@ -43,6 +43,7 @@ public class LearnerHandlerMetricsTest { private MockLearnerHandler learnerHandler; private long sid = 5; + private CountDownLatch allSentLatch; Review comment: Should this be volatile? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services