From dev-return-80746-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue May 7 14:27:36 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B347518064C for ; Tue, 7 May 2019 16:27:35 +0200 (CEST) Received: (qmail 26262 invoked by uid 500); 7 May 2019 14:27:35 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 26251 invoked by uid 99); 7 May 2019 14:27:34 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 May 2019 14:27:34 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] [zookeeper] anmolnar commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK Message-ID: <155723924982.16412.8994100535865350463.gitbox@gitbox.apache.org> Date: Tue, 07 May 2019 14:27:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anmolnar commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK URL: https://github.com/apache/zookeeper/pull/919#discussion_r281657160 ########## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/NettyServerCnxnTest.java ########## @@ -184,4 +191,135 @@ public void run() { assertArrayEquals("unexpected data", "test".getBytes(StandardCharsets.UTF_8), contents); } } + + @Test + public void testEnableDisableThrottling_secure_random() throws Exception { Review comment: Perhaps I've asked this before, but why don't you use junit's parameterized tests? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services